Bug#823849: RFS: opengrm-ngram/1.2.2-1 -- opengrm n-gram library
On 09/05/2016 23:58, Jakub Wilk wrote:
> * Giulio Paci <giuliopaci@gmail.com>, 2016-05-09, 17:40:
>> git://anonscm.debian.org/collab-maint/opengrm-ngram.git
>
> Let me see:
>
>> + * Import Upstream version 1.2.2.
>> + (Closes: #707826)
>
> This sounds as if #707826 was a request to package new upstream release.
Right: added a separate entry for the FTBFS bug.
>> + - replace automake1.13 with automake
>
> This is inaccurate: the previous version has build-depends on automake1.11.
Fixed.
>> + * Refresh 1005_fix_libraries_linking.patch and + 1002_remove_bashisms.patch.
>
> I wouldn't call changes to 1002_remove_bashisms.patch a "refresh". The content of the patch is now radically different.
Right, I separated the entry and expanded the change description.
>> + * Drop 1003_fix_spelling.patch and 1004_fix_ngram_h_file.patch.
>
> If you are dropping them because they were applied upstream, then please say so explicitly.
This was the reason, so I added a note about it.
>> + * Change Section from text to science.
>
> Note that updating d/control is not enough to convince dak that the package is in the new section. After the upload, you'll have to file a bug against ftp.d.o to update it.
> (Use "reportbug ftp.debian.org", then choose "override".)
Thank you for this note, I was not aware of it... And I will need for another package as well.
>> + Running tests in parallel with make resulted in many tests
>> + failure, due to several file access race conditions. This
>
> Typo: failure -> failures
Fixed.
> Typo in NEWS:
> Compatability -> Compatibility
Added and forwarded a new patch for it.
Bests,
Giulio
Reply to: