Bug#823474: RFS: btrfs-progs/4.5.2-0.1~exp1

[Gianfranco Costamagna <costamagnagianfranco@yahoo.it>]

Hi,

>Done.  I did a couple of nme runs in a sid chroot, and then fixed

>lintian errors.  It might be possible to compact the debian/copying
>stanza, but my goal was maximum correctness so I didn't take any
>risks.  Lintian said that copyright entries for config/* weren't
>necessary.  Is this true?  I removed them on the assumption that they
>were.


seems that config.* files, have a GPL-3+ while install-sh an MIT license (or
expat, didn't check).

I leave to you, adding them or not.
(I would even strip them from the sources, not sure why they have such a strict license)


>One more concern:  E - Package closes bugs in a wrong way.  Bug
>#801192 does not belong to this package.  I know this is a "teaching
>moment."  What is the correct way to tag #801192 (owned by
>btrfs-tools) so that it can be closed by btrfs-progs?  I'd like to
>send the email to control@ myself, and I suspect this needs to be done
>before you upload this package. ;-)


as you want, the bug will be closed anyway, so feel free to experiment with reassign tag, or
just don't care :)

additional review:
1) please run autoreconf
2) copyright missing:

question: what about using dpkg-divert?
Honestly I never tried it, so I don't know if it is useful, used in packaging or somewhere else
and I'm too lazy to check it by myself :p

https://codesearch.debian.net/results/dpkg-divert/page_0
seems somebody is using it out there

also, can you please fix the lintian stuff too?
talking about:

W dbg-package-missing-depends
btrfs-tools-dbg <-- not sure if worth a fix
I duplicate-long-description
btrfs-tools btrfs-tools-dbg
I duplicate-short-description
btrfs-tools btrfs-tools-dbg

thanks!

Gianfranco
(I think about putting the package in deferred/15, to leave xnox time to review it too)