Bug#822362: RFS: mitlm/0.4-2 -- MIT Language Modeling toolkit
On 23/04/2016 22:00, Jakub Wilk wrote:
> Control: owner -1 !
>
> * Giulio Paci <giuliopaci@gmail.com>, 2016-04-23, 21:13:
>> https://anonscm.debian.org/cgit/collab-maint/mitlm.git
>
> Let me see:
>
>> + * Add 0001_add_am_prog_ar_to_configure.ac.
>
> Please explain (in the changelog) what this patch does.
Done.
>> + * Allow recent autotools usage.
>
> I have no idea what this means...
I think just an error... Essentially it summarizes the two points above.
>> + * Update Vcs-* and Homepage fields in control file.
>
> Nitpicking: Vcs-* and Homepage are unrelated, so I'd put them in separate items.
Done.
>> + * Update watch file.
>
> Hmm, but there are no tags at the new location. Have you talked to upstream about this?
I think I can be considered upstream for this package, as I am "maintaining" it since a few years (essentially since last official release).
I left the reference to Paul because he is still available (I have active communication with him) to answer questions that I may not know how to answer.
My plan is to use tags for the next releases, but there are no commit that are exactly reflecting the current one.
>> + * Update Source field in copyright.
>
> Policy §12.5 says that the “the copyright file must say where the upstream sources (if any) were obtained”, but they are not available (and never were AIUI) at the new
> location. So I think keeping the original Source would be better^Wless wrong, at least until the tarball Debian uses appears on the new site.
Reverted the change until a new release will be available, then I will switch again.
> spellintian(1) says:
> debian/patches/1003_make_logger_more_flexible.patch: Allows to -> Allows one to
Fixed.
Bests,
Giulio
Reply to: