Bug#814865: RFS: helm-synth/0.6.2-3 [ITP]

[Matthew Tytel <matthewtytel@gmail.com>]

Thanks for the review.. sigh... A lot to do.

I could use a little guidance though. I'm using this library called JUCE:
https://www.juce.com/
https://github.com/julianstorer/JUCE

It looks like a lot of the problems are stemming from that project.
And, it's a little big and unfamiliar to take on in a short amount of time.

This library should probably be its own Debian package, but I'm

probably not the best person for that job. What do you think I should

do in this situation?

Thanks again for the review!

Matt

On Mon, Apr 4, 2016 at 3:06 PM, Gianfranco Costamagna <locutusofborg@debian.org> wrote:

control: owner -1 !
control: tags -1 moreinfo

Hi, lets review:

control:
please use autoreconf
std-version is 3.9.7

debian/menu: drop per ctte decision

copyright: lots of embedded libraries and copyright/licenses missing.

BSD / ISC / zlib/libpng / libpng / Apache?

not sure how many more, and with embedded libraries this is even worse.

automatic checks (check-all-the-things)

$ codespell --quiet-level=3

$ cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not find or open any of the paths given.'

# Parsing /proc/cpuinfo is not portable at all, use /sys instead.
$ grep -rF /proc/cpuinfo .
./JUCE/modules/juce_core/native/juce_linux_SystemStats.cpp:        return getConfigFileValue ("/proc/cpuinfo", key);

$ flawfinder -Q -c .
(my eyes are bleeding now)

you need to fix a lot of stuff before getting this one into Debian

cheers,

G.