On Wed, Apr 06, 2016 at 11:39:46AM -0300, Tiago Ilieve wrote:
> On 6 April 2016 at 09:49, Mattia Rizzolo <mattia@debian.org> wrote:
> > And also I now notice that you're missing a python (or python-all)
> > build-dep, which is kind of redundant but still mandated.
>
> Actually, I don't know what I was thinking at the moment, but those
> Python 2 dependencies aren't needed at all. The package is built
> against Python 3 only.
ah, heh.
> I've also added DEP-8 tests[2]
> for those who can't be run at build time. Both test suites are passing
> now.
umh, reading it like that looks to me that it runs against the sources
only. Am I wrong? DEP-8 tests should test against the installed
packages.
> Worth mentioning that the package will FTBFS because right now
> "python3-path-and-address" is still on the NEW queue:
[..]
> Should we wait for dependencies of a package arrive at the archive
> before uploading it?
No need: I have it locally, and ftpmaster will notice these things and
accept them in order.
> > BTW, i really much don't mind WIP commits instead of sending diffs to
> > paste.d.n ;)
>
> Sorry. I try avoid pushing "dirt commits". Next time I'll push them in
> a temporary branch.
I see, well temporary branches to be deleted, rebased, squashed, etc are
totally fine by me too.
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: http://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature