Bug#818921: RFS: python-neovim-gui/0.1.1-1 [ITP]
control: owner -1 !
control: tags -1 moreinfo
Hi Victor,
- please meld changelog in a single entry
-
install_requires = [
'neovim>=0.1.3',
'click>=3.0',
'pygobject'
]
please add them as build-dependencies and check that python3:Depends do its job
upstreaming the desktop file and the svg file is appreciated :)
(also installing it inside setup.py, to avoid overrides in debian packaging)
I usually prefer instead of a clean override something like
echo "neovim_gui/screen.c" >> debian/clean
does -pie breaks the build? why?
(link error? maybe adding some -l flags is enough?)
check-all-the-things review:
pyflakes3 .
For now I think it is enough, please let me know if you can address (some/all) the above issues
and I'll do probably another trip (and upload)
the packaging looks good to me
cheers,
Gianfranco
Reply to: