Bug#816363: RFS: fgetty/0.7-0.1 [NMU] -- very small, efficient, console-only getty

[Dmitry Bogatov <KAction@gnu.org>]

> 1) I see you dropped patches, but they aren't applied upstream.
> fgetty-login.diff
> ro-dev.diff

I knew what I did, but feel free to disagree with my reasoning.

fgetty-login.diff essentially just renames /bin/login1 to /bin/fgetty-login.
I find it confusing, when binaries are renamed. Either way, /bin/login{1,2}
are never invoked directly, so I considered installing them into /lib/fgetty.
It would eliminate need in manpage, which is barely useful. WDYT?

ro-dev.diff demotes chown/chmod error, if it is caused by read-only
/dev. I do not understand why anyone would want it, /dev is rw by
default Debian installation. Yes, just tried, `getty' from util-linux
issues warning, not error in case of ro /dev, but can anyone explain me
why it is good thing?

> please explain, and comment on changelog.
>
> (the cvs diff I suspect is fully applied, right?)

Right.

> 2) +export DEB_BUILD_OPTIONS =3D noautodbgsym
> why?

3 of 4 binaries are statically linked with no debug information.  So
the only debug symbols for checkpassword(1). Since `$(wc -l
checkpassword.c) = 93` I see little use of debug package.

> as a general note, please try to be more verbose in your work (changelog,=
>  comments in rules file), to save time to your sponsor, and to make the c=
> ommunity aware of your intentions.
> I can't understand if your changes above are something you did by mistake=
> , or intentionally, in any case, some more verbosity doesn't hurt too muc=
> h :)

Sure. Will do better next time.

-- 
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Keep-In-CC: yes
X-Web-Site: sinsekvu.github.io