Bug#809308: RFS: cl-asdf/3.1.6 [ITA] - Another System Definition Facility
Thank you for the heads up, Mattia. Since January, I am working on
several projects and unfortunately forgot to finish the packaging.
I have uploaded a new version which addresses these:
> On Thu, Dec 31, 2015 at 12:22:43PM +0100, Kambiz Darabi wrote:
>> > - $ codespell --quiet-level=3
>> > ./debian/changelog:1247: Seperate ==> Separate
>>
>> done
>
> It's not.
But hopefully now :)
> * creating and removing build-stamp is useless with short form dh (e.g.
> it's a makefile thing that's uneeded here)
done
> * maybe you could drop 'doc/*log' and 'doc/version.texinfo' in
> debian/clean and avoid another override?
done
> * in the `make -C doc all`, please use `$(MAKE)` instead of just `make`.
done
> * make is called should be called by dh_auto_build in this case, let it
> do it's job?
I tried without the first $(MAKE) which is still there:
> override_dh_auto_build:
> $(MAKE)
> $(MAKE) -C doc all
> ln -sf build/asdf.lisp .
but then it looks like make is not being called, as the default target
'build/asdf.lisp' creates the build/ directory, but I get an error
related to the missing of that dir:
> fakeroot debian/rules binary
> dh binary
> dh_testroot
> dh_prep
> debian/rules override_dh_auto_install
> make[1]: Entering directory `/home/darabi/wrk/asdf/asdf'
> ln -sf build/asdf.lisp .
> make[1]: Leaving directory `/home/darabi/wrk/asdf/asdf'
> dh_install
> cp: cannot stat ‘debian/tmp/build/’: No such file or directory
> dh_install: cp -a debian/tmp/build/ debian/cl-asdf/usr/share/common-lisp/source/cl-asdf// returned exit code 1
> make: *** [binary] Error 2
> dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2
So I left the $(MAKE) call in override_dh_auto_build. If you know how to
work around this, I can of course implement the change.
> * Debian has resources, is there a real reason not to run tests at build
> time? "extensive tests are performed before release of the orig.tgz
> on different implementations, so we don't need to perform any test"
> it's quite untrue: stuff breaks even *after* the release, just because
> some dependency changes behaviour or such.
I am willing to work towards a version which runs the tests but as
Francois-René Rideau, who is the previous maintainer and packager has
pointed out in [1], it requires a lot of work which involves creating
several additional Debian packages for the test dependencies.
I would like to ask for continuing the current practice of not running
the tests at build time, but promise to look into the issue in future.
Thanks
Kambiz
[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=809308#29
Reply to: