I can't sponsor you (I'm just a contributor) but since I packaged
python-jellyfish on my own as I didn't see your ITP first, let me
chime in to be of some help.
# d/watch
It is correct, but from the contents of the orig.tar.gz I see you
have used the one from Github (that contains the docs/ etc) and not
the one from PyPi. Since that's the one you are advertising, in the
future please take the PyPi one (or rework the watch file).
(I have opened an issue[1] to make upstream include the docs/ on the
tar.gz).
# d/changelog
Upstream has a published 0.5.2, please package it :).
# d/control
Personal preference: indent and comment which are needed for tests,
such as here[2].
# d/patch
Please upstream them (in case they aren't already in 0.5.2).
# d/copyright
It's missing:
```
Files: jellyfish/test.py
Copyright: 2015 James Turk
2010 Michael Stephens
License: BSD-2-clause
Files: setup.py
Copyright: 2015 James Turk
2010 Michael Stephens
2012 Petr Hosek
License: BSD-2-clause
Files:
cjellyfish/mra.c
cjellyfish/damerau_levenshtein.c
Copyright: 2015 James Turk
2013 Danrich Parrol
License: BSD-2-clause
Files: cjellyfish/porter.c
Copyright: 2015 Martin Porter
License: BSD-2-clause
Comment:
The original author licenses it as:
"The software is completely free for any purpose, unless notes at the
head of the
program text indicates otherwise (which is rare). In any case, the
notes about
licensing are never more restrictive than the BSD License."
.
(see: http://tartarus.org/~martin/PorterStemmer/ ,FAQ, #1 )
.
The current author licenses it as the rest of the project.
```
# DPMT
If you want to maintain this package under the Debian Python Modules Team,
please read https://python-modules.alioth.debian.org/policy.html and apply
to the team :).
Don't hesistate to chime in at #debian-python @ irc.oftc.net
# gbp.conf
I haven't looked much, but please make sure the repo complies with [3].
# lintian
there's a spelling error in manpage: accomodate accommodate (upstream
the fix).
[1]: https://github.com/jamesturk/jellyfish/issues/48
[2]:
https://anonscm.debian.org/cgit/python-modules/packages/python-proselint.git/tree/debian/control
[3]: https://github.com/diego-plan9/python-jellyfish-mentors
--
Víctor Cuadrado juan
E-Mail: <me@viccuad.me>, OpenPGP-Key-ID: 0xA2591E231E251F36
Key fingerprint: E3C5 114C 0C5B 4C49 BA03 0991 A259 1E23 1E25 1F36
My signed E-Mails are trustworthy.
Attachment:
signature.asc
Description: OpenPGP digital signature