Bug#814008: RFS: vbackup/1.0.1-1
Hi Mattia,
Thanks for the review.
On 23/02/16 17:45, Mattia Rizzolo wrote:
On Sun, Feb 07, 2016 at 02:06:39PM +0000, Stefanos Harhalakis wrote:
Dear mentors,
I am looking for a sponsor for the 1.0.1-1 release of "vbackup".
This is normally handled by Vincent Bernat but he's currently away.
Hi!
stuff I don't like and would prefer to see changed:
* please meld the 2 changelog entries, the 1 minute, 14 seconds older
one never hit the archive anyway.
Done
* current standards-version is 3.9.7, check against it.
Done. No changes needed
* what's "Set localstatedir to /var"? I can't see anything relevant in
the packaging part.
That's because it is now calling "dh" which does this. The previous
version was running the configure script directly and was not passing
--localstatedir, thus defaulting to PREFIX/var
* what are those debian/.ci-name and debian/.ci-tgz files?
Leftovers from my personal CI setup. Removed.
* in d/rules, the following is useless if you use debhelper compat 9
(you don't):
# see EXAMPLES in dpkg-buildflags(1) and read /usr/share/dpkg/*
DPKG_EXPORT_BUILDFLAGS = 1
include /usr/share/dpkg/default.mk
why did you add them?
Removed. I don't remember if it was from the initial debian/ dir
creation or whether they were added later by me.
* you bumped the dependency on debhelper, but compat is still 5.
clearly, read debhelper(7) if you bump it.
Done. I read the manpage for changes between 5 and 9 and didn't notice
anything that applies to vbackup.
* is debian/dirs really really really needed? if it is, you build
system is broken and you may as well fix it.
It's not. Removed
* FYI, in d/rules I personally find the following comment useless
# main packaging script based on dh7 syntax
Cleared
* you don't do hardening, can you consider enabling it? (see
wiki.d.o/Hardening)
I had a look and didn't see anything that applies. vbackup is purely
shell scripts. Am I missing something?
* in d/copyright, the years are 2006-2012, I'm confident you want to
bump them.
Corrected
The new package is in mentors and is lintian clean:
http://mentors.debian.net/package/vbackup
Do you want to give it another shot?
Thanks,
Stefanos
Reply to: