Hi Afif, On Wed, 2016-02-24 at 21:16 -0800, Afif Elghraoui wrote: > Thanks for working on this package. Thank you for taking a look at the package! > I took a look at it and found some issues. The first is the requirement > of the additional file stp_2.1.2+dfsg.orig-outputcheck.tar.gz. You > should not be directly using anything outside the packaging directory. The archive corresponds to OutputCheck, a build dependency that runs STP's regression tests. OutputCheck doesn't have a Debian package, and based on my discussion with upstream developers and a Debian developer that sponsored the first upload of STP to New, this was the proposed approach. OutputCheck is, to the best of our knowledge, used only by STP, and the upstream developers have a plan of re-basing STP tests on a different testing framework soon. Furthermore, OutputCheck is not actively developed any more. I also found examples of other Debian packages being done in the same way - having a small build dependency shipped as an archive. I don't have a reference supporting that, but my memory tells me I saw an example with a Debian Perl package. > There's at least one other issue--in debian/control, the Vcs URLs should > be pointing to the packaging repository rather than upstream. Ok, I didn't know this about the Vcs URL! Recently I added a Git repo for STP on Alioth. Should I put the repo's URL to d/control? > I didn't check further because the package currently doesn't build. Can you clarify this? It builds in pbuilder with defaults settings. > Most such problems can be found by running lintian, but we first need > the package to build in a minimal environment. I haven't seen the Vcs problem in a report by Lintian. Usually I use the "-i -I" options. Can you be specific, i.e. which other options should I use that reveal issues you are talking about? -- Regards, Marko Dimjašević <marko@cs.utah.edu> . University of Utah https://dimjasevic.net/marko . PGP key ID: 1503F0AA Learn email self-defense! https://emailselfdefense.fsf.org
Attachment:
signature.asc
Description: This is a digitally signed message part