Bug#815518: RFS: ircii/20151120-1 [QA Upload]
Hi Daniel,
Daniel Echeverry wrote:
> I updated the package with other changes. the new changelog is:
Thanks for your effort to revive and revamp that package. (I was a
ircii user before I switched to irssi.) I'd sponsor the upload, but
there's at least one show-stopper -- plus a few nice-to-have things:
> * debian/control
> + Use HTTPS in Vcs field
Minor nitpick: There are two Vcs-* fields, not just one.
But to the real issue: You changed the Vcs-Git URL to
https://anonscm.debian.org/collab-maint/ircii.git -- which gives a
404. Please use https://anonscm.debian.org/git/collab-maint/ircii.git
instead. (For me that's the only show stopper, the remainders are only
minor issues which won't keep me from sponsoring.) "duck" found this
issue btw., too:
E: debian/control: Vcs-Git: https://anonscm.debian.org/collab-maint/ircii.git: ERROR (Certainty:certain)
fatal: repository 'https://anonscm.debian.org/collab-maint/ircii.git/' not found
And when you're on it, please switch the Vcs-Browser from
https://anonscm.debian.org/gitweb/?p=collab-maint/ircii.git;a=summary
to where it redirects, i.e.
https://anonscm.debian.org/cgit/collab-maint/ircii.git. (Using
https://anonscm.debian.org/git/collab-maint/ircii.git -- without the
"c" of "cgit" works fine, too.)
Apropos git: Did you do that work on a clone of
https://anonscm.debian.org/git/collab-maint/ircii.git and is that
published somewhere so that we can push it back? Or shall I just "gbp
import-dsc" the uploaded package afterwards?
> * debian/rules
> + Migrate to dh tiny rules.
While I'd sponsor it without the following change proposition, I
generally wouldn't hardcode any version in debian/rules, even if the
old package did that, too:
override_dh_install:
dh_install
echo "set CLIENT_INFORMATION ircii-debian 20151120" > debian/ircii/usr/share/ircII/script/version
I'd rather do it this way:
override_dh_install:
dh_install
echo "set CLIENT_INFORMATION ircii-debian `dpkg-parsechangelog -SVersion | sed -e 's/-[^-]*$//'`" > debian/ircii/usr/share/ircII/script/version
Or if you want to include the Debian package version, just remove the
sed call:
override_dh_install:
dh_install
echo "set CLIENT_INFORMATION ircii-debian `dpkg-parsechangelog -SVersion`" > debian/ircii/usr/share/ircII/script/version
If you want, I can also change these things myself before uploading.
But if you want to do any of these changes yourself, feel free to do
so and ping me again afterwards.
There are though a few things found by duck, I'd like to fix myself, preferable before uploading:
E: debian/patches/0003-Add-ioption-to-local-include-paths-so-they-do-not-co.patch:2: Email: Tobias Klauser tklauser@access.unizh.ch : ERROR (Certainty:possible)
tklauser@access.unizh.ch: No MX entry found.
tklauser@access.unizh.ch: No A entry found.
tklauser@access.unizh.ch: No AAAA entry found.
E: debian/copyright:48: Email: tklauser@access.unizh.ch: ERROR (Certainty:possible)
tklauser@access.unizh.ch: No MX entry found.
tklauser@access.unizh.ch: No A entry found.
tklauser@access.unizh.ch: No AAAA entry found.
Tobias' new e-mail address is tklauser@distanz.ch.
For completeness, here's are the remaining issues found by duck, for
which I don't have a proper answer to:
E: debian/copyright:21: Email: dalewis@cs.Buffalo.EDU: ERROR (Certainty:possible)
dalewis@cs.Buffalo.EDU: No MX entry found.
dalewis@cs.Buffalo.EDU: No A entry found.
dalewis@cs.Buffalo.EDU: No AAAA entry found.
And this looks like a rather temporary issue, it's just horribly slow:
E: debian/control: Homepage: http://www.eterna.com.au/ircii/: ERROR (Certainty:certain)
Curl:28 HTTP:200 Timeout was reached Operation timed out after 59618 milliseconds with 0 out of 2735 bytes received
Regards, Axel
--
,''`. | Axel Beckert <abe@debian.org>, http://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
`- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
Reply to: