control: tag -1 moreinfo
On Sat, Feb 06, 2016 at 08:03:07PM +0000, Jose M Calhariz wrote:
> The packages are very old. I could not update sawfish without
> updating it's build-depends. That was cared and are now on
> experimental. So is time for sawfish, the latest changes are on
> collab-maint.
Umh, couldn't you turn d/rules to use the dh sequencer?
I anyway see a lot of nowadyas obsolete stuff that could really easily
be removed, for example:
* you include quilt.make: the package is source/format 3.0 (quilt), dpkg
takes care of that already. that would also remove the quilt B-D
(and the line in the clean target).
* all that if/else/endif staff can go away if you stop calling manually
./configure and rely in dh_auto_configure
* maybe use dh-autoreconf instead of manually instead of copying
config.{sub,guess} and calling autoconf, etc...
* most (all?) of that clean rule is deal correctly by dh_auto_clean
* the source targe should follow policy §4.9 (so, named get-orig-source)
more:
* d/changelog
+ trailing whitespaces at line 24
+ "Remove upstream debian directory." => what's this? do you mean the
upstream tarball and you removed it? source fomat 3.0 already does
it by itself, i don't understand what you did.
* d/control
+ the Build-Conflicts on automake1.4 is unneeded.
+ the Build-Depends on dpkg-dev is unneeded
+ there is an ongoing effort since a couple of weeks to switch Vcs-Git
to stop using the git:// protocol, please switch Vcs-Git to https.
(there is also a lintian tag for this, btw)
+ and of course Vcs-Browser http => https
+ wait, why the sawfish binary would need an explicit dependency on
librep9 ?? ain't that provided by shlibs:Depends?
* maybe you can consider to drop the -dbg package in favour of the
automatically built dbgsym?
* d/menu: drop it?
* bump debhelper compat level to 9?
* d/copyright: consider write a copyright-format 1.0 one? at a first
sight doesn't look too much work.
* trying to build it: "configure: error: cannot locate librep >= 0.92.3"
so you miss a build-dep.
+ didn't you try to build it in a clean chroot?
* once fixed the b-d, I get another ftbfs, with a lisp backtrace ending:
'error--> (file-error "No such file or directory" "rep/data/tables")'
go figure...
* so it seems you have symlinked doc dir. do as it pleases you, but
anyway please drop those manually built .postinst file if their only
use it that one.
* please try to get a more lintian clean package.
* please try to get a reproducible buildable package, from what I see it
wouldn't be difficult at all.
pretty sure I would find something more with a deeper look, even more if
I could build it...
there are 57 open bugs, are you telling me none of them get closed by
this upload? :\
I anyway expect some bug triaging done…
good work! :)
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: http://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature