Bug#808546: RFS: node-restore/0.3.0-1 [ITP] -- simple RemoteStorage server written in Node.js
Control: owner -1 !
Control: tags -1 moreinfo
Hi, lets review:
http://debomatic-amd64.debian.net/distribution#unstable/node-restore/0.3.0-1/lintian
lintian needs fixing
I: node-restore source: xs-testsuite-header-in-debian-control xs-testsuite
I: node-restore source: quilt-patch-missing-description web-finger-path.patch
I: node-restore source: quilt-patch-missing-description remove-google-fonts.patch
I: node-restore source: quilt-patch-missing-description relative-paths.patch
I: node-restore source: quilt-patch-missing-description bug-fix-modified-timestamp.patch
changelog is too huge (usually "initial release" closes: #ITP is enough). but you can leave something if needed,
just not 45 lines.
(also an empty line at the bottom)
I'm not sure "node-restore" is a correct group/user name (policy wise)
debian/server.js
why do you start a service that is not available upstream? having code that starts automatically, and code
not even provided by upstream is kind of worrying.
"Redirect /.well-known /restore/.well-known"
why?
it shouldn't be needed to install the files in ".apache2"
Installed correctly, opened the web page:
http://localhost:8020/restore/signup
bug 404 not found.
also
http://localhost:8020/restore/
is 404
cheers,
Gianfranco
Reply to: