[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#802298: RFS: php-htmlawed/1.1.20-2 [ITP] -- htmLawed PHP code to purify & filter HTML



On Saturday 02 January 2016 06:30 PM, Mattia Rizzolo wrote:
> On Sat, Jan 02, 2016 at 05:14:42PM +0530, Bhuvan Krishna wrote:
>> Fixed all the above bugs and uploaded to mentors. Please have a look at
>> the source files.
>> http://mentors.debian.net/debian/pool/main/p/php-htmlawed/php-htmlawed_1.1.20-1.dsc
>
> umh, ok, but in doing this you also did other changes, the of which I
> don't like the followings:
> * you removed debian/watch  => ??? why?
Because there is no consistency of naming the upstream packages. Though
the version numbers, changelog is maintained but name of the zip file is
not consistent.
> * you added an override_dh_install, so you could run a chmod.  please
>   override dh_fixperms instead.
Fixed this by replacing dh_install with dh_fixperms
>
>


Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: