Bug#809573: RFS: isomaster/1.3.13-1
Control: owner -1 !
Control: tags -1 moreinfo
Hi
1)
+-DEFAULT_VIEWER ?= firefox
++DEFAULT_VIEWER ?= sensible-broswer
bad typo is bad.
2)
some lintian stuff needs fixing
http://debomatic-amd64.debian.net/distribution#unstable/isomaster/1.3.13-1/lintian
-e.g. copyright in dep5 (trivial stuff to me)
-command menu to remove
-desktop file
-prebuilt doxygen documentation?
3) rules file looks outdated, can you please use the new dh calls?
something like that maybe?
export PREFIX=/usr
%:
<TAB>dh $@ --parallel
also ICONPATH and MYMANPATH seems useless, since the Makefile defaults to them.
4) some little warnings you might want to fix too
bkWrite.c: In function ‘bk_write_image’:
bkWrite.c:382:14: warning: ‘pathTableJolietSize’ may be used uninitialized in this function [-Wmaybe-uninitialized]
rc = writeVolDescriptor(volInfo, sRealRootDrOffset,
^
bkWrite.c:382:12: warning: ‘mPathTableJolietLoc’ may be used uninitialized in this function [-Wmaybe-uninitialized]
rc = writeVolDescriptor(volInfo, sRealRootDrOffset,
^
bkWrite.c:382:12: warning: ‘lPathTableJolietLoc’ may be used uninitialized in this function [-Wmaybe-uninitialized]
bkWrite.c:382:14: warning: ‘sRootDirSize’ may be used uninitialized in this function [-Wmaybe-uninitialized]
rc = writeVolDescriptor(volInfo, sRealRootDrOffset,
^
bkWrite.c:382:12: warning: ‘sRealRootDrOffset’ may be used uninitialized in this function [-Wmaybe-uninitialized]
rc = writeVolDescriptor(volInfo, sRealRootDrOffset,
^
bkWrite.c:379:9: warning: ‘svdOffset’ may be used uninitialized in this function [-Wmaybe-uninitialized]
wcSeekSet(volInfo, svdOffset);
^
5) somewhat important:
the build is not verbose, please if possible make it so.
and consider applying a patch similar to the attached one, to not override flags anymore
(and upstream it)
(not sure if all of them needs a "?", but seems to work).
"?=" actually means: assign this value if no other value is already defined.
(so you don't override flags from Debian build system)
cheers,
G.
--- isomaster-1.3.13.orig/Makefile
+++ isomaster-1.3.13/Makefile
@@ -42,11 +42,11 @@ DEFAULT_VIEWER ?= sensible-browser
# programs used in the Makefiles:
export CC ?= gcc
-export AR = ar
-export RM = rm -f
-export INSTALL = install
-export CP = cp
-export ECHO = echo
+export AR ?= ar
+export RM ?= rm -f
+export INSTALL ?= install
+export CP ?= cp
+export ECHO ?= echo
VERSION = 1.3.13
--- isomaster-1.3.13.orig/bk/Makefile
+++ isomaster-1.3.13/bk/Makefile
@@ -6,7 +6,7 @@ OBJECTS = bkRead7x.o bkAdd.o bkDelete.o
CFLAGS += -Wall -pedantic -std=gnu99 -Wundef -Wcast-align -W -Wpointer-arith -Wwrite-strings -Wno-unused-parameter
# the _FILE_OFFSET_BITS=64 is to enable stat() for large files
-CPPFLAGS = -D_FILE_OFFSET_BITS=64
+CPPFLAGS += -D_FILE_OFFSET_BITS=64
ifdef WINDOWS_BUILD
CPPFLAGS += -DWINDOWS_BUILD
--- isomaster-1.3.13.orig/iniparser-2.17/Makefile
+++ isomaster-1.3.13/iniparser-2.17/Makefile
@@ -3,22 +3,22 @@
#
# Compiler settings
-CC = gcc
-CFLAGS = -O3 -fPIC
+CC ?= gcc
+CFLAGS ?= -O3 -fPIC
# Ar settings to build the library
-AR = ar
-ARFLAGS = rcv
+AR ?= ar
+ARFLAGS ?= rcv
-SHLD = ${CC} ${CFLAGS}
-LDSHFLAGS = -shared -Wl,-Bsymbolic -Wl,-rpath -Wl,/usr/lib -Wl,-rpath,/usr/lib
-LDFLAGS = -Wl,-rpath -Wl,/usr/lib -Wl,-rpath,/usr/lib
+SHLD ?= ${CC} ${CFLAGS}
+LDSHFLAGS ?= -shared -Wl,-Bsymbolic -Wl,-rpath -Wl,/usr/lib -Wl,-rpath,/usr/lib
+LDFLAGS ?= -Wl,-rpath -Wl,/usr/lib -Wl,-rpath,/usr/lib
# Set RANLIB to ranlib on systems that require it (Sun OS < 4, Mac OSX)
# RANLIB = ranlib
-RANLIB = true
+RANLIB ?= true
-RM = rm -f
+RM ?= rm -f
# Implicit rules
--- isomaster-1.3.13.orig/iniparser-2.17/test/Makefile
+++ isomaster-1.3.13/iniparser-2.17/test/Makefile
@@ -2,12 +2,12 @@
# iniparser tests Makefile
#
-CC = gcc
-CFLAGS = -g -I../src
-LFLAGS = -L.. -liniparser
-AR = ar
-ARFLAGS = rcv
-RM = rm -f
+CC ?= gcc
+CFLAGS ?= -g -I../src
+LFLAGS ?= -L.. -liniparser
+AR ?= ar
+ARFLAGS ?= rcv
+RM ?= rm -f
default: all
Reply to: