On Thu, Dec 31, 2015 at 12:22:43PM +0100, Kambiz Darabi wrote:
> > - $ codespell --quiet-level=3
> > ./debian/changelog:1247: Seperate ==> Separate
>
> done
It's not.
> Thanks
ok, now it looks way better. just a few more and then we're good :)
* Debian has resources, is there a real reason not to run tests at build
time? "extensive tests are performed before release of the orig.tgz
on different implementations, so we don't need to perform any test"
it's quite untrue: stuff breaks even *after* the release, just because
some dependency changes behaviour or such.
* creating and removing build-stamp is useless with short form dh (e.g.
it's a makefile thing that's uneeded here)
* maybe you could drop 'doc/*log' and 'doc/version.texinfo' in
debian/clean and avoid another override?
* make is called should be called by dh_auto_build in this case, let it
do it's job?
* in the `make -C doc all`, please use `$(MAKE)` instead of just `make`.
So, if you fix the abive 5 bullet points (and the typo in the
changelog), or explain why you chose to don't do them in a sane way,
it'll just upload it :)
nice work!
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: http://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature