control: tag -1 moreinfo
control: owner -1 !
On Sun, Nov 08, 2015 at 01:24:34PM +0100, Jörg Frings-Fürst wrote:
> Package: sponsorship-requests
> Severity: normal
>
> Dear mentors,
>
> I am looking for a sponsor for my package "liwc"
I'm up for sponsoring it, but the following is something I want (or
would like, anyway) to see changed before:
> * New debian/source.lintian-overrides to override warning about googlecode.
As pabs said, that's not a thing to override. "currently no new
upstream code hosting" is not a good reason. Anyway, please nag
upstream about it.
* Vcs-* points to ajk's private repository. maybe copy it to
collab-maint or somewhere and maintain it there? If you don't want to
maintain it in git, then please drop those fields.
+ please use https and cgit in Vcs-Browser
* please remove the trailing whitespace in debian/control:15
* the patch is marked as not-needed. why? actually that's a change
that ough to be forwarded (even if lintian nowadays doesn't care
anymore)
* in the changelog "add myself as maintainer", when referring to the
control file seems kida imprecise, maybe use "set" instead of "add"
* consider enabling the hardening (adding this in d/rules
`export DEB_BUILD_MAINT_OPTIONS=hardening=+all` is enough)
* I tried to build it and it fails,
http://debomatic-amd64.debian.net/distribution#unstable/liwc/1.21-2/buildlog
In file included from /usr/include/string.h:634:0,
from ccmtcnvt.c:82:
/usr/include/publib/strutil.h:67:7: error: expected identifier or '(' before '__extension__'
char *strndup(const char *, size_t);
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: http://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature