control: tag -1 moreinfo
On Wed, Dec 16, 2015 at 01:45:02PM +0100, Gergely Pilisi wrote:
> I am looking for a sponsor for my package "eclipse-titan":
Ok, first, a question: do you do your debian packaging in git?
And, here is a review:
* trailing whitespace on the changelog line.
* maybe you're happy to discover tools like `wrap-and-sort`, to wrap the
Build-Depends and Depends line (and sort other stuff, and removing
trailing whitespaces in some other files)
* please don't cp files that way in d/rules, I find that ugly. instead,
use a debian/eclipse-titan.install file. See dh_install(1) for more
info. On a related note, I prefer using $(CURDIR) instead of $$(pwd)
+ this will also make debian/eclipse-titan.dirs useless
+ if you need to rename files dh-exec can help you a bit, if you want
* during the compilation there are several errors like
./TTCN3.hh:58:39: fatal error: RT1/TitanLoggerApiSimple.hh: No such file or directory
is this to be expected & ok?
* is there a way to have a more verbose build, showing all the command
line?
* you told me that you could get it to build with hardening-wrapper,
well, to me it doesn't (see below) :)
* can you enable parallel building? (see debhelper(7))
* debian/copyright is totally inadequate.
+ personally I won't be totally happy without a copyright following
copyright-format 1.0
+ anyway, please pick a random package from the archive and try having
a look at what a copyright file normally looks like.
About ditching hardening-wrapped in favour of just using what
dpkg-buildflags do:
whatever I use the .dsc you provided, just removed hardening-wrapper or
enable the hardening build flags using DEB_BUILD_MAINT_OPTIONS, the
build fails with
In file included from jnimw.cc:8:0:
jnimw.h:14:17: fatal error: jni.h: No such file or directory
compilation terminated.
../Makefile.genrules:87: recipe for target 'jnimw.o' failed
So there is not much of a comparison to do. Maybe you built the package
with an hardening-wrapper without the fix for #801597 ?
And btw, having a verbose build is kinda important to check for the
build flags, hardening, etc.
I might have other points to say, but let's go gradually, uh? :)
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: http://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature