Bug#807627: RFS: taskd/1.1.0+dfsg-1 [ITP]
Control: reopen -1
Am Freitag, den 11.12.2015, 02:51 +0100 schrieb Sebastien Badia:
> Package: sponsorship-requests
> Severity: normal
>
> Dear mentors,
>
> I am looking for a sponsor for my package "taskd"
>
> * Package name : taskd
> Version : 1.1.0+dfsg-1
> Upstream Author : Paul Beckingham <paul@beckingham.net>
> * URL : http://taskwarrior.org
> * License : MIT
> Section : utils
>
> It builds those binary packages:
>
> taskd - Synchronisation server for taskwarrior
>
> To access further information about this package, please visit the
> following URL:
>
> http://mentors.debian.net/package/taskd
>
> Alternatively, one can download the package with dget using this
> command:
>
> dget -x http://mentors.debian.net/debian/pool/main/t/taskd/taskd_1.
> 1.0+dfsg-1.dsc
>
> Note: This is the first upload of taskd package (ITP).
>
> Thanks in advance, cheers,
>
> Seb
Patches:
- Please forward the patches to upstream more aggresively.
For example, /tmp/taskd.pid is a BUG, because pid files are supposed to
be in run (or var/run as legacy path)
- Reproducible builds should not be only for Debian, forward them to
make them aware of the importance of reproducible builds.
- There is one patch that has not an "Forwarded" indication.
- Some patches have been applied upstream, please add a "Applied-
Upstream" Header (bonis: with a reference to be commit, if easily
found.)
- get-orig-source.sh seems to remove some files, however they
should be also mentioned in d/copyright Files-Excluded and also
explain why they are removed and who it would be dfsg-non-free
otherwise. (README.source)
Looking at the script, it seems that you are not repacking because of
DFSG problems, but just to stip unneeded files. If you do that, "dfsg"
would be wrong, use "ds" or "repack" instead.
- postinst seems to fiddle with the config file, which is installed by
the package. This is discouraged, as this will lead in subsequent
installations to a prompt asking the user what to be done
(The conf file has been modified ....) This is actually a RC bug
(Policy 10.7.3 -- must not ask uneccessary questions)
I recommend either install a file already populated with (sane)
defaults OR not to ship the (empty) conffile at all but to create it
during install. (Note, when not shipping the conffile,you also have to
handle purges in postrm manually)
Nitpicks:
- trailing whitespaces in README.Debian
- TODO.Debian mentions the init.d script as not yet present.
- d/control: dh-systemd does not need a versioned dep.
- d/copyright: the comment for the debian section is not needed
- prefer using d/clean instead of override_dh_autoclean
- d/taskd.dirs is not needed.
The conffile thing is a show stopper, otherwise the package seems
ready.
I did not perform copyright review yet.
Tobi
Reply to: