Bug#804697: RFS: libsass-python/0.9.1-1 [ITP] -- libsass-python -- SASS for Python
Hi Gianfranco and thanks a lot for taking a close look to my packaging draft,
the new packaging so far :
http://mentors.debian.net/debian/pool/main/libs/libsass-python/libsass-python_0.9.3-1.dsc
> 1) control:
> python-all, python3-all,
> python-all-dev, python3-all-dev,
>
> I guess the all-dev is a superset of the all package, so you can remove it
missed that one, done, nice
> 2) rules:
> export PYBUILD_NAME=libsass
>
> should make both python-libsass.install and python3-libsass.install useless
> (I did not try the above)
Actually there is a bunch of files installed by default, especially some test
directories. So I striped down the content to something close to the core
library, that's why I specified content in those files.
> 3) the manpage should be upstreamed
The upstream developer explained there is some generated documentation and I
added a patch to have a separate man page generate for sassc utility.
So now the manpage comes from upstream code.
https://github.com/dahlia/libsass-python/pull/104
> 4) it needs a new libsass to enter unstable before it can be sponsored, but I fail to see any bug against libsass
I checked with the maintainer of libsass and he could help :) :
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=806732
> 5) testsuite needs to be enabled, please provide logs of failures
Indeed. I've got hard time to make it work because setup.py tried to fetch
libsass online for some distutil test case. So I submitted the package as-is
having in mind to fix that while some can already review the work do so far :)
It's now running the tests fine for all specified version of python :
python2.7:
-----------------------
Ran 105 tests in 0.561s
OK
-----------------------
python3.5:
-----------------------
Ran 105 tests in 0.807s
OK
-----------------------
python3.4:
-----------------------
Ran 105 tests in 0.674s
OK
-----------------------
> check-all-the-things:
>
> $ codespell --quiet-level=3
> ./sass.py:524: conjuction ==> conjunction
> ./sassutils/wsgi.py:21: Everytime ==> Every time
>
>
> pep8 --ignore W191 .
> (lots)
> $ pyflakes .
> ./sasstests.py:937: 'sys' imported but unused
> ./docs/conf.py:15: 'warnings' imported but unused
>
> $ pyflakes3 .
> ./sasstests.py:937: 'sys' imported but unused
> ./docs/conf.py:15: 'warnings' imported but unused
>
I'm not familiar with all those check tools and that's good to know.
I provided a patch to the upstream (not including it in the package though).
https://github.com/dahlia/libsass-python/pull/107
> uscan --report-status
> Processing watchfile line for package libsass-python...
> Newest version on remote site is 0.9.2, local version is 0.9.1
> libsass-python: Newer version (0.9.2) available on remote site:
> https://github.com/dahlia/libsass-python/archive/0.9.2.tar.gz
> (local version is 0.9.1)
Latest version so far got updated to 0.9.3 and I used that one.
> copyright file is outdated.
> ./docs/conf.py:copyright = u'2012, Hong Minhee'
>
> (the year)
I'll send a note to the upstream developer, good catch!
> the license name seems Expat, not MIT
> https://www.debian.org/legal/licenses/mit
mmm, actually, I just checked again, but I generated the base debian/
directory with dh-make -c mit and it does specify MIT as the name.
Is that deprecated ?
F.
Reply to: