Bug#804644: RFS: flashybrid/0.19 [ITA]
Control: tags -1 moreinfo
Control: owner -1 !
Hi Tim and Thibaut
(Thibaut do you have any keyring issue that you can't upload? I see your key has been dropped because
too weak, maybe you can take the opportunity to make a new and shiny one!
https://wiki.debian.org/Keysigning/Offers)
lets review:
I see this change
1)
--- flashybrid-0.18/ramstore 2014-04-08 14:38:07.000000000 +0200
+++ flashybrid-0.19/ramstore 2015-05-17 14:50:32.000000000 +0200
@@ -23,7 +23,6 @@
/var/lib/logrotate
/var/lib/mysql
/var/log
-/var/run
/root
please document in changelog.
2) same for bump of std-version
3) what about converting the rules file to plain dh calls?
almost everything can be droopped
README* can become a debian/docs file (man dh_installdocs section FILES)
4) compat level should be 9
5) debhelper >=9
6) priority please consider making it optional (but I think extra is the correct place)
7) I'm not sure postinst and postrm are actually useful, please investigate
8) copyright would be nice to have in format machine readable
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
9) please consider converting to quilt format
the other stuff looks good to me :)
cheers,
G.
Reply to: