Bug#804513: RFS: xtrkcad/1:4.2.1-1
Control: owner -1 !
Control: tags -1 moreinfo
Hi Daniel,
lets review:
1) compat level should be 9, and debjelper >=9
(and mention it in changelog)
2) the repo seems on collab-maint, so please push changes and uncomment it
3) copyright is nice to have in
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
form
4) priority should be optional, not extra to me
5)
--- xtrkcad-4.0.2/debian/source/include-binaries 1970-01-01 01:00:00.000000000 +0100
+++ xtrkcad-4.2.1/debian/source/include-binaries 2015-11-09 00:27:01.000000000 +0100
please remove that file
6) debian/source/options too
7) please think about upstreaming the desktop file
8) please mention all the changes since the previous releases (changelog is for users, so even a "packaging restyling" or
a "remove wrapper.sh" file and replace with a desktop file might be worth a mention)
9) grep copyright . -Ri shows many unlisted folks
10) licensecheck * -r shows many missing copyrights, e.g. BSD MIT(expat?)
11) some files are in publicdomain license
http://creativecommons.org/licenses/publicdomain/
12) license seems to be GPL-2+, not GPL-2
13) something more
covered by the Creative Commons Attribution-ShareAlike 2.5 License Agreement.
14) debian/menu, please remove for ctte decision
15: please think about a simpler rules file, such as
%:
dh $@ --parallel
override_dh_auto_configure:
dh_auto_configure -- -D CMAKE_BUILD_TYPE=RelWithDebInfo \
-D XTRKCAD_USE_GETTEXT=ON \
-D XTRKCAD_USE_GTK=ON \
-D XTRKCAD_USE_GTK_CAIRO=ON \
-D XTRKCAD_USE_LAYOUTCONTROL=ON ../)
override_dh_install:
rm -f debian/xtrkcad/usr/share/xtrkcad/COPYING
dh_install
and the manpage issued with a
echo "debian/xtrkcad.1" > debian/xtrkcad.manpages
(and please forward manpage upstream)
note: I didn't test the above rules file, but it should work, and please build with RelWithDebInfo aka with
debugging symbols and let dh_strip do its job (and maybe you might think about providing a dbg package, even
if it will come later)
cheers,
G.
Il Lunedì 9 Novembre 2015 3:33, Daniel E. Markle <dmarkle@ashtech.net> ha scritto:
Package: sponsorship-requests
Severity: normal
Dear mentors,
I am looking for a sponsor for my package "xtrkcad"
* Package name : xtrkcad
Version : 1:4.2.1-1
Upstream Author : Martin Fischer <m_fischer@users.sourceforge.net>
* URL : http://xtrkcad.org
* License : GPL-2
Section : editors
It builds those binary packages:
xtrkcad - Model Train Track CAD Program
To access further information about this package, please visit the following URL:
http://mentors.debian.net/package/xtrkcad
Alternatively, one can download the package with dget using this command:
dget -x http://mentors.debian.net/debian/pool/main/x/xtrkcad/xtrkcad_4.2.1-1.dsc
More information about hello can be obtained from http://www.example.com.
Changes since the last upload:
* new upstream version, closes: #622924
* packaging updates and fixes; removes patchset for help system as is now
integrated upstream
* turnout naming fix from upstream, closes: #784423
--
Daniel E. Markle
http://ashtech.net/~dmarkle/
Reply to: