Bug#804169: RFS: libjreen/1.2.0-1

[Gianfranco Costamagna <costamagnagianfranco@yahoo.it>]

Control: owner -1 !
Control: tags -1 moreinfo



Hi
let's review:


1) changelog: you need to have only one entry and an ITP bug closed
https://www.debian.org/devel/wnpp/

2) priority: optional


"Pre-Depends:" I guess you can drop them, because they aren't needed anymore
for multiarch packages


3) 3rdparty, what about packaging the libraries here separately?

4)debian/*.install
I would avoid this

usr/lib/libjreen.so.1* usr/lib/%DEB_HOST_MULTIARCH%


but I would like something like
usr/lib/*/*.so.*

and so on

you should patch the rules file to use multiarch directly

e.g.
DEB_HOST_MULTIARCH    ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH)

%:
dh $@ --dbg-package=libjreen-dbg --parallel

override_dh_auto_configure:
dh_auto_configure -- -DLIB_SUFFIX=$(DEB_HOST_MULTIARCH)


this will allow you to remove all the .in hacks

BTW this also need to patch cmake like this (I guess, didn't try)
DESTINATION lib${LIB_SUFFIX}/pkgconfig


to
DESTINATION lib/${LIB_SUFFIX}/pkgconfig


(and upstream this patch)

5) copyright:
./alttoolbar_rb3compat.py:# Copyright (C) 2012 - Agustin Carrasco


check-all-the-things:


$ codespell --quiet-level=3
./src/error.cpp:149: occured  ==> occurred
./src/vcard.h:47: adress  ==> address
./src/registrationmanager.cpp:125: Unkown  ==> Unknown
./src/error.h:130: occured  ==> occurred


$ cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not find or open any of the paths given.'

(something)


$ grep -riE 'fixme|todo|hack|xxx' .
(something)


something for upstream
$ licensecheck * -r 2> /dev/null |grep incorrect

3rdparty/icesupport/bytestream.cpp: LGPL (v2.1 or later) (with incorrect FSF address)



Please note: some of them might be nitpicks/false positive, please check and report back :)
thanks!

(I know it is a lot of work, but the initial review is always the most difficult for both parts)

cheers,

Gianfranco