Bug#804100: RFS: rhythmbox-plugin-alternative-toolbar/0.14.0-1~debian [ITP]

[Gianfranco Costamagna <costamagnagianfranco@yahoo.it>]

Control: owner -1 !
Control: tags -1 moreinfo

Hi
let's review:


1) changelog: you need to have only one entry and an ITP bug closed
https://www.debian.org/devel/wnpp/
2) changelog: ~debian makes no sense, please remove
3) compat: 9
4) control: debhelper (>=9)
   std-version 3.9.6
   priority: optional

5) copyright:
./alttoolbar_rb3compat.py:# Copyright (C) 2012 - Agustin Carrasco


missing

years are outdated "2014" is not good, I would say "xxx-2015" where xxx is the first copyright

Also the first line I guess should use this url
Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
(not sure if they are the same)

6) tarball seems to be not the upstream downloadable from github one
(also it contains the git history)

7) debian/docs: empty?
please add something or drop it
(bonus point, use something to translate README.md into a pdf/html page?)


8) debian/watch file is missing please add one
https://wiki.debian.org/debian/watch

check-all-the-things:

$ grep -riE 'fixme|todo|hack|xxx' .
./alttoolbar_repeat.py:    # will be the hacky solution
./alttoolbar_repeat.py:    # This is a hacky old method to 'repeat' the current song as soon as it
./alttoolbar_repeat.py:    # This is a hacky old method to 'repeat' the current song as soon as it


$ suspicious-source
./img/rb-symbolic-icons.tar.gz


$ pyflakes .
(lot of stuff)


$ pyflakes3 .
(lot of stuff)

$ pep8 --ignore W191 .

(lot of stuff)


$ find -type f \( -iname '*.po' -o -iname '*.pot' \) -exec msgfmt --check --check-compatibility --check-accelerators --output-file=/dev/null {} \;
(lot of stuff)




Please note: some of them might be nitpicks/false positive, please check and report back :)

thanks!

(I know it is a lot of work, but the initial review is always the most difficult for both parts)

cheers,

Gianfranco