On Thu, Oct 22, 2015 at 11:18:08AM (+0200), Thomas Goirand wrote: > Hi Seb, > > A quick review then. > > Both Ubuntu LTS and Debian Stable have version >= 3.3.1 of python-lxml, > so you don't need to specify the version in debian/control. > > Same remark for paramiko. > > Your package doesn't run any of the upstream tests. Why? > > Both -lxml and -paramiko could be in build-depends-indep. > > In the doc's conf.py, there's "sphinx.ext.intersphinx". This is to be > patched out, so that the package doesn't do network access during build. Hi! Thanks zigo for the review, Just fixed the package according your valuable comments, if you have a bit of time in order to re-take a look it would be cool :-) Thanks in advance! https://tracker.debian.org/pkg/python-ncclient http://mentors.debian.net/package/python-ncclient http://mentors.debian.net/debian/pool/main/p/python-ncclient/python-ncclient_0.4.5-1.dsc Seb
Attachment:
signature.asc
Description: PGP signature