[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#803626: RFS[ITP]: edge-addition-planarity-suite -- Suite of planarity-related graph algorithms



Control: owner -1 !
Control: tags -1 moreinfo


Hi Julien,

1) rules: the MULTIARCH stuff is just useless :)
(maybe also all the other stuff, except for the wl-asneeed

2) build log:
libtoolize: putting auxiliary files in `.'.
libtoolize: copying file `./ltmain.sh'
libtoolize: Consider adding `AC_CONFIG_MACRO_DIR([m4])' to configure.ac and
libtoolize: rerunning libtoolize, to keep the correct libtool macros in-tree.
libtoolize: Consider adding `-I m4' to ACLOCAL_AMFLAGS in Makefile.am.


3) please consider providing a dbg package (even if Debian is switching to ddbg)

4) dh-autoreconf with a version constraint... well, I'm not sure why but seems mostly
useless to me

5) the pre-depends for multiarch should be useless now

6) I'm really unsure about the empty shlibs files

7) /usr/share/man/man1/planarity.1
this belongs to dh_installman not dh_install

the other stuff looks good to me.
(there are some build warnings about "*scan*" and ignoring return value,
you might want to forward bugs/patches upstream)

cheers,

G.


Reply to: