Bug#802848: RFS: gnome-twitch/0.1.0-1 [ITP]
Am 30.10.2015 um 10:13 schrieb Gianfranco Costamagna:
> well, I started packaging in 2013 and I didn't provide good packages on the first tries.
> (actually I'm still doing packaging mistakes)
>
> You seem to be a better packager than me, and you told you are on your first packaging experience...
> this is awesome :)
Thanks!
I think what helped me the most (apart from reading lots of
documentation) was looking at existing packages in the archive.
I specifically looked at packages using the SCons build system, since
that is not natively supported by debhelper (like autotools is for example).
That way I could just observe how packagers used debhelper to build with
SCons and transfer that method to meson.
I do think though that the whole debhelper toolchain with all the dh_*
commands could use some more straight forward documentation, but maybe I
just haven't found that yet.
>
> as said before, if you don't like the solution feel free to revert the change, I'm fine
> with both solutions, as long as you are aware of pro/cons of both.
I like that solution. It isn't any harder to maintain and at least
offers a little bit of convenience if I ever need to split the package.
> now another little issue:
> ../print_git_version.sh: 3: [: unexpected operator
>
>
> building in a clean environment shows this error.
> basically there is no git command, so use your best solution to patch the source
> or add git to build-dependencies (or just discard the issue if you think this is
>
> a non-issue)
I think there are two issues. The first is that, for some reason, bash
is not used to execute the script, but some other shell, maybe dash
(even though the shebang line points to bash).
The == operator inside the [] brackets is a bash-ism, so it will not
work in dash.
The second issue is, as you said, the use of git. But adding git to the
build dependencies would not solve this, since the .git directory is not
contained in the original tarball, so git couldn't extract the version
from it anyways.
But I think all this is a non-issue, since the script is only used to
tell the (upstream) build system the git version so the "about" dialog
in the application can show that version number. If the script fails
(like it does now) the build system falls back to the hardcoded version
(0.1.0 in this case), and those are the versions that get packaged anyways.
> $ find -type f -iname '*.desktop' -exec desktop-file-validate {} \;
> ./data/com.gnome-twitch.app.desktop: error: value "GTK;GNOME;AudioVideo;Player;Video" for string list key "Categories" in group "Desktop Entry" does not have a semicolon (';') as trailing character
>
I will fix that together with the lintian informational warning
"desktop-entry-lacks-keywords-entry", once I read about making and
managing patches with quilt. This will be a good exercise :)
Also, desktop-file-validate seems like a useful program, I wonder why
lintian doesn't use that. Maybe I will also look into that.
Thanks again for your time.
--
Tim
Reply to: