Control: tags -1 + moreinfo On Thu, 29 Oct 2015 20:54:31 -0500 Zorian M wrote: > I am looking for a sponsor for my package "safetyblanket" I don't intend to sponsor this package but here is a review: There are some blocking issues: The font has a different copyright holder to the rest of the package and the license for it is all rights reserved. I doubt anyone has permission to distribute this font. Please remove the package from mentors and suggest that upstream remove the font from github. The copyright holder and license for AnAL.lua is not documented in debian/copyright. None of the stuff created by upstream has a copyright notice or license in it, where did you get the zlib and CC-BY-SA-4.0 licenses from? I would suggest that upstream needs to add this info to the git repo. There are some other things that I noticed: I assume you have sent the manual page and desktop file upstream. I thought it was possible to install .love files directly to /usr/bin and have love be automatically run via binfmt_misc? https://lists.debian.org/20130208143007.GC6533@debian https://lists.debian.org/20130224200226.GB21647@debian It might be nice if upstream were to add a build/install system. -Pdebian/safetyblanket_build doesn't look necessary. override_dh_installinit doesn't look necessary. I would suggest running wrap-and-sort -sa Some of the images contain pre-rendered text. I would suggest that upstream render the text at runtime so the game could add translations. A bunch of the images were produced in the GIMP, do you know if upstream saved the multi-layer XCF files or discarded them? I noticed slam.lua and AnAL.lua are also in the mrrescue source package, I guess this means that they are embedded code copies. https://wiki.debian.org/EmbeddedCodeCopies Automatic checks: lintian P: safetyblanket source: debian-watch-may-check-gpg-signature P: safetyblanket: no-upstream-changelog check-all-the-things $ luacheck . <lots of warnings> -- bye, pabs https://wiki.debian.org/PaulWise
Attachment:
signature.asc
Description: This is a digitally signed message part