Bug#802848: RFS: gnome-twitch/0.1.0-1 [ITP]

[Tim Dengel <tim.dengel.debian@gmail.com>]

Am 26.10.2015 um 19:00 schrieb Gianfranco Costamagna:
> Hi, the packaging looks good to me (note: I didn't do a full review)

Hi, thanks for looking at my package!

> however I don't like your dh_auto_install target override.
> 
> dh_auto_install should install into debian/tmp, not into debian/package.

I installed into debian/package because "man dh_auto_install" told me
that "[...]the files are installed into debian/package/ if there is only
one binary package. In the multiple binary package case, the files are
instead installed into debian/tmp/ [...]".
Although there is no reason given why it should be debian/package in one
case and debian/tmp in the other. What's the difference?

> I propose you to use dh_install like this:
> 
> override_dh_install:
> 
>     DESTDIR=$(CURDIR)/debian/gnome-twitch ninja -C build install
> 
> what do you think?

I overrode dh_auto_install because that is where "normally" (when using
autotools for example) the "make install" stage of the process is
executed, right?
And the "ninja install" command would be my equivalent of that "make
install".
After that, I thought, dh_install could be used to install files that
were not picked up by the call to make (or ninja in my case).

If that is not the case, what difference does overriding dh_install make
in contrast to overriding dh_auto_install? Both seem to produce a
working package for me.

Also, the command you proposed would also install into
debian/gnome-twitch, but at the top you said I should be installing into
debian/tmp? I'm a little confused ;)

> you could also use MAKE=ninja and
> $(MAKE) during the calls, to keep it simple and possible to easily change the build system.

While writing an answer to this, I just realized that make also takes
the -C option, I didn't know that before.
So yes, that would probably be a good idea, I'll do that.

--
Tim