On Fri, 23 Oct 2015 13:59:55 -0300 Jorge Niedbalski wrote:
> I am looking for a sponsor for my package "ultraeasy"
I don't intend to sponsor this but here is a review:
DEB_AUTO_UPDATE_* aren't looked at by dh-autoreconf or debhelper, only
by CDBS, which this package isn't using. Remove them from debian/rules.
libultraeasy should be named after the upstream library and include the
SONAME. If upstream doesn't have proper ABI tracking then they should
be making the library a private library instead and you can drop the
library package and the dev package.
Normally DH_VERBOSE is commented out in debian/rules.
I would suggest running wrap-and-sort -sa to wrap debian/control and
other files.
Please add some upstream metadata:
https://wiki.debian.org/UpstreamMetadata
If you contact upstream, please mention our upstream guide:
https://wiki.debian.org/UpstreamGuide
The upstream NEWS and ChangeLog files are not very useful, they should
fill them out or remove them altogether.
Upstream includes several files that should not be in the git tree
since they are automatically copied in by autoreconf:
missing
install-sh
depcomp
config.sub
config.guess
INSTALL
The upstream .gitignore is missing the above files and probably more.
Automated checks:
build:
dpkg-gencontrol: warning: package ultraeasy: unused substitution variable ${shlibs:Depends}
lintian:
W: ultraeasy source: binaries-have-file-conflict libultraeasy ultraeasy usr/lib/x86_64-linux-gnu/libultraeasy.so.0
W: ultraeasy source: binaries-have-file-conflict libultraeasy ultraeasy usr/lib/x86_64-linux-gnu/libultraeasy.so.0.0.0
W: ultraeasy source: binaries-have-file-conflict libultraeasy-dev ultraeasy usr/lib/x86_64-linux-gnu/libultraeasy.so
P: ultraeasy source: debian-watch-may-check-gpg-signature
P: libultraeasy-dev: no-upstream-changelog
W: libultraeasy-dev: new-package-should-close-itp-bug
E: libultraeasy-dev: extended-description-is-empty
W: ultraeasy: package-name-doesnt-match-sonames libultraeasy0
E: ultraeasy: missing-dependency-on-libc needed by usr/bin/ultraeasy and 1 others
P: ultraeasy: no-upstream-changelog
W: ultraeasy: new-package-should-close-itp-bug
I: ultraeasy: description-synopsis-might-not-be-phrased-properly
E: ultraeasy: extended-description-is-empty
W: ultraeasy: binary-without-manpage usr/bin/ultraeasy
W: ultraeasy: non-dev-pkg-with-shlib-symlink usr/lib/x86_64-linux-gnu/libultraeasy.so.0.0.0 usr/lib/x86_64-linux-gnu/libultraeasy.so
I: ultraeasy: no-symbols-control-file usr/lib/x86_64-linux-gnu/libultraeasy.so.0.0.0
W: libultraeasy: package-name-doesnt-match-sonames libultraeasy0
P: libultraeasy: no-upstream-changelog
W: libultraeasy: new-package-should-close-itp-bug
I: libultraeasy: description-synopsis-might-not-be-phrased-properly
E: libultraeasy: extended-description-is-empty
I: libultraeasy: no-symbols-control-file usr/lib/x86_64-linux-gnu/libultraeasy.so.0.0.0
check-all-the-things:
$ cme check dpkg
cme: using Dpkg model
loading data
Reading package lists... Done
Building dependency tree
Reading state information... Done
Warning in 'control source Build-Depends:1' value 'devscripts (>= 2.10.7)': unnecessary versioned dependency: devscripts >= 2.10.7. Debian has squeeze-security -> 2.10.69+squeeze4; squeeze -> 2.10.69+squeeze4; squeeze-backports -> 2.12.4~bpo60+1; wheezy-security -> 2.12.6+deb7u2; wheezy -> 2.12.6+deb7u2; wheezy-backports -> 2.14.11~bpo70+1; jessie-kfreebsd -> 2.15.3; jessie -> 2.15.3; jessie-backports -> 2.15.8~bpo8+1; stretch -> 2.15.9; sid -> 2.15.9;
Use of uninitialized value $desc in concatenation (.) or string at /usr/share/perl5/Config/Model/Backend/Dpkg/Control.pm line 169.
Warning: skipping value because of the following errors:
Undefined mandatory value.
Use of uninitialized value $desc in concatenation (.) or string at /usr/share/perl5/Config/Model/Backend/Dpkg/Control.pm line 169.
Warning: skipping value because of the following errors:
Undefined mandatory value.
Use of uninitialized value $desc in concatenation (.) or string at /usr/share/perl5/Config/Model/Backend/Dpkg/Control.pm line 169.
Warning: skipping value because of the following errors:
Undefined mandatory value.
checking data
Configuration item 'control binary:libultraeasy Description' has a wrong value:
Undefined mandatory value.
$ codespell --quiet-level=3
./depcomp:308: Maked ==> Marked, made
./depcomp:318: Maked ==> Marked, made
./depcomp:322: Maked ==> Marked, made
./config.sub:1320: nto ==> not | disable due to \n
./src/facade.c:162: availabe ==> available
./src/util.h:45: Appart ==> Apart
$ cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not find or open any of the paths given.'
[src/ultraeasy.h:26]: (error) The code contains unhandled characters (character code = 0xe2). Checking continues, but do not expect valid results.
[src/ultraeasy.h:26]: (error) The code contains unhandled characters (character code = 0x80). Checking continues, but do not expect valid results.
[src/ultraeasy.h:26]: (error) The code contains unhandled characters (character code = 0x9c). Checking continues, but do not expect valid results.
[src/ultraeasy.h:26]: (error) The code contains unhandled characters (character code = 0x9d). Checking continues, but do not expect valid results.
[src/ultraeasy.c:102]: (error) Returning/dereferencing 'ultraeasy' after it is deallocated / released
[src/util.c:218]: (error) va_start() or va_copy() called subsequently on 'ap' without va_end() in between.
[src/util.c:218]: (error) va_list 'cp' used before va_start() was called.
[src/util.c:219]: (error) va_list 'cp' used before va_start() was called.
$ find \( -name .git -o -name .svn -o -name .bzr -o -name CVS -o -name .hg -o -name _darcs -o -name _FOSSIL_ -o -name .sgdrawer \) -prune -o -empty -print
./ChangeLog
$ flawfinder -Q -c .
<lots of output>
$ licensecheck --check=. --recursive --copyright . | grep -F 'GENERATED FILE'
./depcomp: GPL (v2 or later) GENERATED FILE
./missing: GPL (v2 or later) GENERATED FILE
./config.sub: GPL (v2 or later) GENERATED FILE
./logs/SnoopyProExport.log: *No copyright* GENERATED FILE
./config.guess: GPL (v2 or later) GENERATED FILE
$ pep8 --ignore W191 .
./logs/join.py:5:5: E225 missing whitespace around operator
./logs/join.py:15:1: W293 blank line contains whitespace
./logs/join.py:15:1: W391 blank line at end of file
# Users of binary packages do not need install instructions.
# So move those instructions to README.install
$ find -type f -iname '*README*' -a ! \( -iname README.md -o -iname README.install \) -exec grep --ignore-case --fixed-strings --with-filename install {} +
./README:For build instructions see INSTALL.
./README: make install
$ grep -riE 'fixme|todo|hack|xxx' .
./src/ultraeasy.c: // Force link layer to set E & S. This is a hack to account for the fact
./src/ultraeasy.c: // we can remove this hack.
./src/ue_link.c: // TODO: validate the MORE bit
$
test -d ./debian &&
! grep -s -q native debian/source/format &&
! test -e debian/upstream/metadata &&
echo 'Please add some upstream metadata: https://wiki.debian.org/UpstreamMetadata'
Please add some upstream metadata: https://wiki.debian.org/UpstreamMetadata
--
bye,
pabs
https://wiki.debian.org/PaulWise
Attachment:
signature.asc
Description: This is a digitally signed message part