Bug#790412: RFS: circus/0.12.0-1
well, it FTBFS on both pbuilder and sbuild environments...
http://debomatic-amd64.debian.net/distribution#unstable/circus/0.12.1+dfsg-1/buildlog
cheers,
G.
Il Giovedì 15 Ottobre 2015 13:48, David Douard <david.douard@logilab.fr> ha scritto:
On 10/15/2015 11:42 AM, Gianfranco Costamagna wrote:
> Control: tags -1 moreinfo
>
> So please ping me as soon as you have fixed the above.
Should be ok (I hope)
David
>
> cheers,
>
> G.
>
>
>
>
> Il Giovedì 15 Ottobre 2015 11:11, David Douard <david.douard@logilab.fr> ha scritto:
> On 10/13/2015 07:17 PM, Gianfranco Costamagna wrote:
>> Control: owner -1 !
>>
>> Hi David
>>
>> quick review:
>
> Thanks,
>
>>
>> 1) control: runtime dependencies:
>>
>> please let python:Depends to its job
>
> indeed
>
>> I see in setup.py
>> install_requires = ['iowait', 'psutil', 'pyzmq>=13.1.0', 'tornado>=3.0']
>>
>>
>> (also: why some dependencies are not listed here?)
>
> some are dependencies for the tests (IIRC), some are optional in circus (imported
> in a try/except), but I prefer to keep them as Build-Depend to ensure these execution
> path are tested. In fact, some of them should be added in the Recommends or Suggests section.
>
>>
>> 2) rules/control: please consider using python3
>>
>
> I do, but one step at a time :-)
>
>>
>> 3) rules:
>> - why you remove examples from build?
>
> because I don't want these in the python package, but only in /usr/share/doc/circus/examples
>
>
>> - "make -C docs" I would use $(MAKE) -C docs
>
> Ok I'll fix that
>
>
>> the other stuff looks good, but I didn't check carefully yet :)
>> (and I didn't try a build&run)
>>
>> cheers,
>>
>> G.
>>
>
>
--
David DOUARD LOGILAB
Directeur du département Outils & Systèmes
+33 1 45 32 03 12 david.douard@logilab.fr
+33 1 83 64 25 26 http://www.logilab.fr/id/david.douard
Formations - http://www.logilab.fr/formations
Développements - http://www.logilab.fr/services
Gestion de connaissances - http://www.cubicweb.org/
Reply to: