Bug#784304: RFS: xerces-c/3.1.2+debian-1 [ITA] -- validating XML parser library for C++
On Fri, Sep 25, 2015 at 11:45:55PM +0200, Tobias Frost wrote:
> Control: owner -1 !
>
> Hi Bill,
>
> let me also take a look at xerces.
>
> As usual, my unsorted list of observations:
>
> - Please rebase your package to the latest version in Debian, to
> include the NMU (3.1.1-5.1) from Salvatore Bonaccorso.
The patch is included in 3.1.2, so the patch added in the NMU is no longer
necessary. But the changelog has been updated to include the NMU entry.
>
> *.doc
> - Don't install CREDITS and README.
Removed.
>
> d/control:
> - (B-D) I think You only need dh-autoreconf, not both dh-autoreconf
> and autotools-dev
Removed autotools-dev
> - please wrap-and-sort...
Done.
> - for doxygen generated dokumentation, do ignore the minified-js
> -linitan (and add an override). Do not fix it with libjs-query, you can
> get broken documentation. (There's a readme in the doxygen pacakge
> about it)
Done.
> - doxygen should go into Build-Depends-Indep.
> (Then you have either update the minimum dpkg-dev version to >= 1.16.2
> or --better-- drop the version requirement -- it is already filfilled
> in old-old-stable.
Done.
>
> I'd turn the java dependency around -- first the headless and then the
> normal one (the buildds will always take the first one, and I guess the
> headless is "leaner" -- but I did not verify this claim )
That makes sense. Done.
>
> d/copyright:
> - The additional copyrights needs to go into the Copyright section of
> the files; then delete the sentence "Additionally, portions..."
The only references to FSF that I find are in the autotools related files:
configure, Makefile.in, aclocal.m4, etc. I don't recall seeing other
packages document those in d/copyright. How is this normally handled?
Likewise the only reference I found to X Consortium is in config/install-sh.
And the only references I found to W3C are in comments talking about various
standards. I don't see anything that looks like it would be copyrighted by
them. I found no references to MIT, ERCIM, or Keio.
Honestly, I'm not sure how to proceed. What do you suggest?
> - Are the years up to date? (currently 1999-2007)
Fixed.
>
> - As you're repacking anyway, please remove the useless Win32 project
> folder-
Done.
>
Best regards,
Bill
Reply to: