Bug#800561: RFS: classified-ads/0.08-1 - internet messaging system
Hi Antti,
Am Donnerstag, den 01.10.2015, 01:28 +0300 schrieb Antti Järvinen:
> Package: sponsorship-requests
> Severity: normal
>
> Dear mentors,
>
> I am looking for a sponsor for my package "classified-ads":
>
> * Package name : classified-ads
> Version : 0.08-1
> Upstream Author : Antti Järvinen <antti.jarvinen@katiska.org>
> * URL : http://katiska.org/classified-ads/
> * License : LGPL-2.1
> Section : net
>
> It builds those binary packages:
>
> classified-ads - Program for displaying classified advertisement
> items
>
> To access further information about this package, please visit the
> following URL:
>
> https://mentors.debian.net/package/classified-ads
>
> Alternatively, one can download the package with dget using this
> command:
>
> dget -x http://mentors.debian.net/debian/pool/main/c/classified-ads/c
> lassified-ads_0.08-1.dsc
>
> More information about classified-ads can be obtained from
> http://katiska.org/classified-ads/.
>
> Changes since the last upload:
> * Qt version change (4->5)
> * Translation system change from dm files of qt to gnu gettext
> * Bitmap conversion produces same binary always. Closes: #794395
> * Networking related bugfixes
>
> Regards,
> Antti Järvinen
>
small issues only, please fix those (or convince me that it is ok) and
ping me again. I'll pull from git.
-> d/changelog
* It is convention when you package a new upstream to have that in the
changelog. As you close upstream bugs, you would write:
"New upstream release. Closes: #794395"
* Because: d/changelog is for Debian changes, not to document
upstream changes. Let those lines go.
* But there are changes do the pacakaging which are not documented:
o removal of B-Ds, adding of README.Source
For practice sharing: When my package is under a repository I try to
have one commit per change topic. This helps to understand which
d/changelog entry correleates to which change.
-> d/README.source
* the procedure you describe is quite standard, so maybe remove it?
otherwise:
* it has some trailing whitespaces.
* you *SHOULD* *REALLY* sign tags, at least the final build
(add this to your gbp.conf)
* you should even consider signing every commit.
http://mikegerwitz.com/papers/git-horror-story
-> your gbp.conf should be only related to the package, not your
(local) build enviorment. You local settings should go into your local
file. See gbp.conf(5).
(As you are upstream: Please also bump the copyright years when you add
or edit files to their header. Its odd to have new file (c) 2013...
NOTE: This is *NOT* something you need to fix for this upload, just a
suggestion to adapt this best practice in the future)
--
tobi
Reply to: