Bug#787148: gambatte review
Hi!
> what about maintaining it under Debian Games Team?
What should I do? Send a message to the mailing list? With all my packages?
> 1) please fix the copyright file
Fixed
> 2) please fix the watch file (ask upstream to tag releases?)
Upstream does not answer people for some months...
> 3) section Games maybe? (that one applies also to mupen64plus-qt)
otherosfs is not better? I'll have to change stuff to /usr/games/ then...
> 4) priority extra? (that one applies also to mupen64plus-qt even if
> games seems to have priority extra)
Changed to optional
> 5) rules file:
> ifneq arch armhf
> make
> endif
>
> why?
>
> I ask why for two reason: does qt have a problem on armhf?
> well, then please correct here
> Architecture: amd64 i386
> I don't think you want to build qt and not ship in a binary for other
archs.
There's a problem with Qt frontend on ARM (I don't remember exactly
what's happening), this is why there's only the sdl port to ARM.
> 6) patches/SDL*
> for the sdl package you might want to add some flag such as
> -I/usr/include/SDL and avoid the patch
> (even if personally I prefer the patch and I'll appreciate to see it
> part of upstream code)
Let's wait upstream merge the makefile PR, to mess with it.
> 7) changelog: "git last version" doesn't explain where did you take and
> when. Please add a 0.5.0~git20150902 or whatever, but asking upstream to
> tag would be better indeed
changed to 0.5.0~git20150322-1, like I said, upstream is vanished.
Thanks for the review!
cheers
sergio-br2
Reply to: