Bug#792144: RFS: cunit/2.1-2.dfsg-3 -- Unit Testing Library for C [ITA]

["a3at.mail@gmail.com" <a3at.mail@gmail.com>]

On Mon, Sep 07, 2015 at 01:14:45PM +0000, Gianfranco Costamagna wrote:
> Hi,
> 
> quick review:
> 
> 1) lintian is complaining about no compat level set.
> I don't see any problem in the compat level set, not sure
> if a bug in lintian or something else...

> 2) d/rules: please use the new dh format, it should be trivial to convert.

Still in progress.

> 3) d/control: do you really need autoconf as b-d? dh-autoreconf should be enough
> (note: I didn't test the above)

Yes, you are right, dh-autoreconf is enough.

> 4) libcunit1-ncurses.override
> 
> 
> are you sure the file is called it correctly? AFAIK the extension should be lintian-override
> (even if I didn't test it)
> 
> for sure such things
> debian/tmp-cunit-ncurses/usr/share/lintian/overrides/libcunit1-ncurses usr/share/lintian/overrides
> 
> 
> are something that I would really like to avoid.

Hm, according to lintian(1):
       "For binary packages, Lintian looks for overrides in a file named usr/share/lintian/overrides/<package> inside the binary package, where <package> is the name of the binary package."

So seems that this is correct, no?

> 5) debian/d*doc-files
> Files: /usr/share/doc/libcunit1-doc/html/*.html /usr/share/doc/libcunit1-doc/html/*.css
> 
> well, I guess an html/* might be enough, right?

Nope, there is /usr/share/doc/libcunit1-doc/html/CUnit_doc.css

> let me know and I'll followup with another review.

Thanks for review, I will write when I will finish with converting it to dh
format, if you have some examples - that can help a lot.

Thanks,
Azat.