[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#797771: RFS: [ITP] tzlocal/1.2-1



Control: owner -1 !

Hi Edward,

The packaging LGTM, however I have some nitpicks for you:

1) d/rules: please do not override dh_install and call dh_auto_install, unless you have a good reason to
do that (I guess this is an error, you don't want to call it twice)

dh_installdocs: please consider having a debian/docs with "README.rst" inside

(and please remove the autogenerated file comments on line 3-4

2) watch file, please consider using "exactly" the pypi version (note: the difference is a comment and an "s",
I don't see why you should use http://)

3) why you remove windows and macos specific stuff? does it hurt?

I'm wondering if removing source files might be source of hidden troubles.

I did some basic testing and the package works correctly on both python and python3.

cheers,

G.


Reply to: