[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#792716: RFS: fdkaac/0.6.2-1 [ITP] -- command line encoder frontend for libfdk-aac



Control: owner -1 !

Control: tags -1 moreinfo


Hi Marius.



some nitpicks:

1) please run a meld COPYING debian/copyright

I see some differences that are MIT/Expat and some minor
differences (like spaces and so on).

Since upstream is using a machine readable copyright I suggest to keep it
bit-bit identic and move maybe the differences (e.g. debian/* packaging) to the
end.

2) upstream provides a way to generate a manpage with pandoc, can you please run it?

3) d/rules:
I don't see the need to run manually autoreconf and cleaning manually the files.

Aren't you satisfied with a simple
"dh $@ --with autoreconf"

default call?

(note: I'm not an auto* fan, so I might miss some missing file or similar issue)

cheers,

G.


Reply to: