Bug#786795: Review: dhcp-probe/1.3.0-11
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Control: owner -1 !
Hi,
let's review.
please use the same tarball as the unstable version (orig tarball)
dpkg-source: error: file /tmp/dhcp-probe_1.3.0.orig.tar.gz has size
214140 instead of expected 213279
1) changelog:
do not remove the previous NMU entry
2) control: bump debhelper to >=9 and remove quilt from b-d
3) why did you remove autoreconf?
4) compat level=9
(man debhelper helps you, this compat level automatically inject flags)
5) bonus points if you convert the rules file in the new dh style :)
the rest looks good (I didn't check all, I stopped some bits after the
above)
cheers,
G.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQIcBAEBCAAGBQJV4BOHAAoJEPNPCXROn13ZXM8P/RwFFL3zE8zwuzCYTfeIv3Tr
ZJ/5BA/bDW9ok5rC05voOxj9TmEazzu/gFRVbgX5d5V52HJhXU7bDE+xdh0cbmg5
Zz0nmbc3k5b+KvulIDKLKzGT36EBPGz7QVg7hE8/zodReACmUuFpfKElQrvBQDut
wpxZ6xivVabgPRmTtaLz0VG7Uxm1l5fh8xeYp2JiVhwN0mtH0/NGgcjAH4nn9Jnu
Gp62sUbfl2jy2f+nM00K7SUsHNVqWsFOOvhP3T18YgZy3pkZlOQD9eOf7CWo0fL/
d0ojSlUAKbqTcYRxqgIzsk3tqYOwCrR7tFJAKp2qqLFTAQznqaZN7xldeAKlOzey
yfrUp+8HWHKZ8R72+nsIR3S00CAeVIIhR25Kj5zf7CnbmH/ZA42IWXldYFUW0U+m
815hmEleJUuWmNPciSlBuGr7REKrRuLBmc5OC+3A2zrYCTPGQ9TdCK5i+pH5tngS
W96xTLXe2s/WJjuJOvuPhRKN9vjTb9kuFeAJ6qP2fzsW2dDOL1TgaevRzWiNGRFE
ZJnrhSCx8M1255yTcSlTBGvc7jZq11C4/KJrA6DaOEEYxaY+POm/n6etlthFbdIh
4rQnchEl1dEXVWwTws+mbIatT7WdAO7iEmfp0Ei1CLIROAE/Uq0CQiNKAXO2Be1p
qAgy+C3Yp7ScSMY+C0JG
=HXtz
-----END PGP SIGNATURE-----
Reply to: