On 25/08/15 00:19, Oxan van Leeuwen wrote: > Hi Thomas, > > On 24-08-15 14:10, Tomasz Buchert wrote: > >Nicely done, but there is one issue. If you modify conffiles in postinst > >it marks them as changed, and this is not something you want to do. > > > >In my branch "tomasz-changes" I followed ADVANCED PROGRAMMING WITH > >DEBCONF section in "man debconf-devel". The outcome is that the config > >file is not tracked by conffiles machinery and hence the problem does > >not exist. Please review. > > Yeah, that's definitely true. Your branch looks good to me. It's probably a > bit cleaner to wrap the config-writing machinery in the postinst in an if [ > "$1" = "configure" ], but I don't think it hurts to execute it for the other > postinst invocations as well. > > Other than that, I don't think there are any remaining issues preventing > upload? Hi, do you understand this lintian warning about incomplete translation? It complains about the templates file, it looks strange to me. Anybody? Cheers, Tomasz > > Cheers, > Oxan >
Attachment:
signature.asc
Description: Digital signature