Bug#795704: RFS: mlucas/14.1-dfsg1 [ITP] -- program to perform Lucas-Lehmer test on a Mersenne number
* Alex Vong <alexvong1995@gmail.com>, 2015-08-16, 19:42:
http://mentors.debian.net/debian/pool/main/m/mlucas/mlucas_14.1-dfsg1.dsc
I don't intend to sponsor this package, but I had a quick look at it:
Don't assume that kfreebsd-any means only kfreebsd-i386 and
kfreebsd-amd64. It is the case for the moment, but it might be in the
future.
"dfsg" should be a suffix to upstream version, not a prefix to Debian
revision. In other words, the version should be something like:
14.1+dfsg-1
"Welcome to ..." is not something I'd write in a package description.
You could reduce size of .orig.tar by ~60% by using xz compression.
You are not supposed to set DEB_BUILD_OPTIONS in debian/rules.
You should honour the options set by the user instead.
Typos (most detected by codespell or spellintian):
$HOME/mlucas.d/ -> $HOME/.mlucas.d/
]nto -> into
accomodate -> accommodate
adn -> and
assigment -> assignment
attept -> attempt
begining -> beginning
correponds -> corresponds
defintion -> definition
differnt -> different
fucntion -> function
garantee -> guarantee
implemetation -> implementation
indicies -> indices
occured -> occurred
overriden -> overridden
sucess -> success
thru -> through
usefull -> useful
whn -> when
--
Jakub Wilk
Reply to: