Bug#794915: RFS: compute/0.4-1 [ITP]

[Gianfranco Costamagna <costamagnagianfranco@yahoo.it>]

Hi Ghislain,

I did a quick review of this package, and looks mostly good to me, but I have some
nitpicks (some errors) for you:

1) you seem to produce a source only library, with no binaries:
   - why do you have an arch:any?
2) you seem to disable the testsuite during the build
                  -DBOOST_COMPUTE_BUILD_BENCHMARKS=OFF \
                  -DBOOST_COMPUTE_BUILD_EXAMPLES=OFF \
                  -DBOOST_COMPUTE_BUILD_TESTS=OFF


In my opinion you should run them, even if you do not install them, because they might be
useful to understand if your library performs well
(cfr websocketpp where I did exactly the same)

3) there is no need to specify the build system when there is no ambiguity
(not a problem at all, just I want to let you aware of this)

4) the copyright file is good, but usually is better for the Debian packaging to choose
the same license as upstream, to ease patch forwarding

Actually expat seems more permissive of the upstream BSL-1.0, so its good




For the copyright where the license is the same you can actually merge
all the copyrights together (just list an * and the list of the copyright owners).
What Debian really care is the License, the copyright of the single file is nice to have
(so please leave it as is), but not strictly mandatory (please somebody correct me if
I'm wrong)

Files: *
Copyright: <list of all the copyright owners>
License: BSL-1.0


might have been good enough.

Since you split all of them is is for sure better, so please leave it as is :)

Let me know how do you want to proceed with the nitpicks, and I'll do another review.


Cheers,

Gianfranco