Bug#791463: Quick review
Hi, following an irc conversation I did a quick look at the package, and looks mostly good.
I never used pmake, so I don't know if this is the right approach, and I can't review fully the rules file.
Just some licenses are not mentioned in the copyright file, and I listed them below
cd_disect.c: BSD
cd_sessions.c: BSD
config.h: *No copyright* UNKNOWN
defs.h: BSD
dirhash.h: BSD (2 clause)
mmc_format.c: BSD
newfs_udf.c: BSD
udf_allocentries.c: BSD
udf_bmap.c: BSD
udf.c: BSD
udfclient.c: BSD
udf_discop.c: BSD
udf_discop.h: BSD
udfdump.c: BSD
udf.h: BSD
udf_readwrite.c: BSD
udf_unix.c: BSD
udf_unix.h: BSD
udf_verbose.c: BSD
uio.c: BSD
uio.h: BSD
uscsilib_machdep.h: BSD
vfs_dirhash.c: BSD (2 clause)
lintian is showing some typos
I: udfclient: spelling-error-in-binary usr/bin/cd_disect removeable removable
I: udfclient: spelling-error-in-binary usr/bin/cd_disect suplied supplied
I: udfclient: spelling-error-in-binary usr/bin/cd_disect transfered transferred
I: udfclient: spelling-error-in-binary usr/bin/cd_disect changable changeable
I: udfclient: spelling-error-in-binary usr/bin/cd_disect lenght length
I: udfclient: spelling-error-in-binary usr/bin/cd_disect seperate separate
I: udfclient: spelling-error-in-binary usr/bin/cd_disect seperately separately
I: udfclient: spelling-error-in-binary usr/bin/cd_disect Auxilliary Auxiliary
I: udfclient: spelling-error-in-binary usr/bin/cd_disect Begining Beginning
I: udfclient: spelling-error-in-binary usr/bin/cd_sessions dont don't
I: udfclient: spelling-error-in-binary usr/bin/cd_sessions integrety integrity
I: udfclient: spelling-error-in-binary usr/bin/cd_sessions removeable removable
I: udfclient: spelling-error-in-binary usr/bin/cd_sessions Auxilliary Auxiliary
I: udfclient: spelling-error-in-binary usr/bin/cd_sessions Begining Beginning
I: udfclient: spelling-error-in-binary usr/bin/mmc_format removeable removable
I: udfclient: spelling-error-in-binary usr/bin/mmc_format lenght length
I: udfclient: spelling-error-in-binary usr/bin/mmc_format Auxilliary Auxiliary
I: udfclient: spelling-error-in-binary usr/bin/mmc_format Begining Beginning
I: udfclient: spelling-error-in-binary usr/bin/newfs_udf dont don't
I: udfclient: spelling-error-in-binary usr/bin/newfs_udf integrety integrity
I: udfclient: spelling-error-in-binary usr/bin/newfs_udf removeable removable
I: udfclient: spelling-error-in-binary usr/bin/newfs_udf Auxilliary Auxiliary
I: udfclient: spelling-error-in-binary usr/bin/newfs_udf Begining Beginning
I: udfclient: spelling-error-in-binary usr/bin/udfclient transfered transferred
I: udfclient: spelling-error-in-binary usr/bin/udfclient dont don't
I: udfclient: spelling-error-in-binary usr/bin/udfclient integrety integrity
I: udfclient: spelling-error-in-binary usr/bin/udfclient removeable removable
I: udfclient: spelling-error-in-binary usr/bin/udfclient Auxilliary Auxiliary
I: udfclient: spelling-error-in-binary usr/bin/udfclient Begining Beginning
I: udfclient: spelling-error-in-binary usr/bin/udfdump dont don't
I: udfclient: spelling-error-in-binary usr/bin/udfdump integrety integrity
I: udfclient: spelling-error-in-binary usr/bin/udfdump removeable removable
I: udfclient: spelling-error-in-binary usr/bin/udfdump Auxilliary Auxiliary
I: udfclient: spelling-error-in-binary usr/bin/udfdump Begining Beginning
and some
W: udfclient: binary-without-manpage usr/bin/cd_disect
W: udfclient: binary-without-manpage usr/bin/cd_sessions
W: udfclient: binary-without-manpage usr/bin/mmc_format
W: udfclient: binary-without-manpage usr/bin/newfs_udf
W: udfclient: binary-without-manpage usr/bin/udfclient
W: udfclient: binary-without-manpage usr/bin/udfdump
(I can't yet sponsor the package, and I guess your sponsor might not care about spelling errors and missing manpages, but please
consider pathing them and report them upstream)
thanks
Gianfranco
Reply to: