Many thanks for having a look at it :) On 07/09/2015 02:02 PM, Wookey wrote: > > Comments: > > 1) You've licenced the debian files (GPL-2+) differently from the > upstream file (BSD-3). That's OK if you only want to contribute on > a GPL basis, but if you don't have strong feelings it usually best > to put the debian packaging under the same licence as upstream, > just for simplicity. ack i changed this to BSD-3 > > 2) The artwork has a different licence but this is not recorded in the > copyright file. Sorry for that i didn't think of checking. As a license synopsis i added 'other'. It am not sure if this is correct but i couldn't find a standard name for that. (i am not sure if its BSD-2) > > 3) No Homepage or vcs fields in the control file > > 4) No multi-arch metadata in the control file > (The binary packages should be Multi-Arch: foreign in this case) > Added 3 and 4 suggestions as well as a watch file. I also fixed some lintian warnings. > Otherwise it looks good. > > I know very little about python and less about its packaging so I > don't know if there are things missing - I'm assuming that: > export PYBUILD_NAME=frozen-flask > %: > dh $@ --with python2,python3 --buildsystem=pybuild > > will just DTRT > TBH this is my first effort in packaging so i got 'inspired' by other similar packages for this (i.e flask-wtf). Thanks a lot, Orestis
Attachment:
signature.asc
Description: OpenPGP digital signature