Bug#785737: RFS: haxe/1:3.0.0~svn6707+dfsg-1 [ITA,RC]

[Jean-Michel Vourgère <nirgal@debian.org>]

Hi

Gabriele Giacone wrote:
>> You added a +dfsg suffix. Good.
>>
>> However, lintian is complaining about the +dfsg :
>> debian-watch-file-should-mangle-version.
> 
> Fixed, pushed, re-uploaded.
>  
>> You should update the watch file to match your change.
>> Please also look at repacksuffix in uscan(1).
>>
>> When removing some non-free files, you should provide a get-orig-source
>> target in your rules file. The easiest way to remove files is to use a
>> DEP5 formated copyright file and to have a line Files-Excluded:. See
>> uscan(1).
> 
> Yeah I've just did it few days ago for ming, convenient.
>  https://anonscm.debian.org/cgit/pkg-flash/ming.git/commit/?id=f7531971a4dd6f37520bc3fe66421e9bea8ed396
> 
> In this case, I've changed packaging as little as possible: no new
> upstream release, no format 1.0 copyright, no Files-Excluded.
> Mainly just to fix RC bug #736596.
> (...)

Cool, but I think your are missing my point.

Because you had to remove two files from the original tar ball, both
"d/rules get-orig-source" and uscan now returns an incorrect source
tarball, I mean it does contain the files you removed. I'm afraid I'm
uncomfortable with that.

Option 1/
Switch to dep5 with Files-Excluded:, remove the get-orig-source target.

Option 2/
Fix the get-orig-source target to remove the files you don't want from
the orig.tar.xz. Right now, it does not do that.
There are many example in existing packages:
https://codesearch.debian.net/results/repack.sh/page_0
Then, the watch file should contain the extra (2nd and) 3rd parameters
to call your repack script. See uscan(1).

Option 3/
At the very least, if you absolutely don't want options 1 or 2, it would
be nice to document that in a README.source file. See policy 4.14, item
4. I would remove the misleading get-orig-source target then.

Or am I missing something?

-- 
Nirgal