Bug#784854: RFS: gtk3-engines-unico/1.0.3+14.04.20140109+repack1-1 [ITA] [RC]
Control: owner -1 !
On Sat, May 9, 2015 at 9:04 AM, James Lu <GLolol1@hotmail.com> wrote:
> Package: sponsorship-requests
> Severity: important
>
> Dear mentors,
>
> I am looking for a sponsor for my package "gtk3-engines-unico". This upload
> fixes an RC bug that caused GTK3 applications to crash with any theme that
> uses the Unico engine, along with some other graphics rendering bugs (tested
> with GTK 3.14).
Ok, now that the package's orphaned status has been clarified, here's
a more thorough review:
Please be more verbose in d/changelog (w.r.t. your changes to
d/control, e.g. like adding/removing build-deps/deps/pre-deps).
debian/rules is missing a get-orig-source target, which is described
in Policy §4.9 [1]. It's not mandatory as per Policy, but since you
also aren't including a debian/watch file (BTW, why did you remove
it?), it's harder for others to verify your orig tarball (and I
consider one or the other mandatory when sponsoring packages).
debian/clean should be redundant now.
Regards,
Vincent
[1] https://www.debian.org/doc/debian-policy/ch-source.html
Reply to: