Bug#783529: RFS: spacenavd/0.6-1 [ITA]

[Vincent Cheng <vcheng@debian.org>]

Control: tag -1 + moreinfo
Control: owner -1 !

Hi Rodolphe,

On Mon, Apr 27, 2015 at 11:10 AM, Rodolphe PELLOUX-PRAYER
<rodolphe@damsy.net> wrote:
> Package: sponsorship-requests
> Severity: normal
>
> Dear mentors,
>
>   I am looking for a sponsor for my package "spacenavd"
>
>  * Package name    : spacenavd
>    Version         : 0.6-1
>    Upstream Author : John Tsiombikas <nuclear@member.fsf.org>
>  * URL             : http://spacenav.sourceforge.net
>  * License         : GPL-3.0+
>    Section         : utils
>
>   It builds those binary packages:
>
>     spacenavd  - daemon for using 3D input devices from 3Dconnexion
>
>   To access further information about this package, please visit the following URL:
>
>   http://mentors.debian.net/package/spacenavd
>
>
>   Alternatively, one can download the package with dget using this command:
>
>     dget -x http://mentors.debian.net/debian/pool/main/s/spacenavd/spacenavd_0.6-1.dsc
>
>   Changes since the last upload:
>   * Imported Upstream version 0.6
>   * Remove initfile patch. We use debian/spacenavd.init anyway.
>   * Remove makefile patch and change spacenavd path in init file.
>   * Use DEP-5 copyright format.
>   * Add upstream example config file.
>   * Source init-functions in init script.
>   * Bump standards version to 3.9.6 and remove obsolete DM-Upload-Allowed field.
>   * Switch to debhelper > 9.
>   * Remove quilt and autotools-dev dependencies.
>   * Set architecture linux-any. Closes: #745177.
>   * Enable systemd service file.
>   * Patch to use /run instead of /var/run.
>   * Enable hardenings flags.
>   * New maintainer. Closes: #781184.
>   * Add Vcs-* fields.
>

debian/copyright is missing a few entries:
- src/serial/*: Copyright 1997-2001 John E. Stone (j.stone@acm.org),
3-clause BSD (+ upstream author)

debian/stamp-patched is useless and can be removed.

debian/patches/run.patch is rather redundant; /var/run is not going to
be removed from Debian in the foreseeable future and will likely be
kept around for compatibility reasons for a long time. If you do
decide to keep it though, please look into adding DEP-3 [1] headers
for it (and any future patch you add).

Your package isn't actually hardened. "export DEB_BUILD_MAINT_OPTIONS
= hardening=+all" in d/rules isn't going to do anything if your
package's build system ignores the hardening flags set by
dpkg-buildflags.

Regards,
Vincent

[1] http://dep.debian.net/deps/dep3/