[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#784854: RFS: gtk3-engines-unico/1.0.3+14.04.20140109+repack1-1 [ITA] [RC]



Control: tag -1 + moreinfo

Hi James,

On Sun, May 10, 2015 at 11:52 AM, James Lu <GLolol1@hotmail.com> wrote:
> Hi,
>
> Okay. Forget what I said about quilt, I don't think it'd fix this particular
> issue either.
>
> Right now, the problem is in the original source (aka the .orig.tar). The
> INSTALL file isn't even installed in the final binary, but just having a
> symlink in the original source is enough to make Lintian complain. Adding a
> debian/clean file only removes the INSTALL file from the extracted tree, but
> not the .orig.tar.gz.
>
> I could add a Lintian override if this is appropriate.

Just from what you've said above, I'd ignore the lintian error
entirely; if INSTALL is never used during the build process or
installed into any of the binary packages produced by your source
package, then source-contains-unsafe-symlink is quite harmless. It
_is_ a valid lintian error though, since the orig tarball upstream
presumably contains an INSTALL file symlinked above the root of the
source package, and removing it via debian/clean doesn't change that.

Where did you obtain this orig tarball? I can't seem to find a tarball
versioned as 1.0.3+14.04.20140109 at [1]; if you actually are rolling
your own tarball instead of using one provided upstream, then why not
get rid of that symlink in your tarball?

Also, this may seem to be a formality, but is this package actually
orphaned? Neither the maintainer nor the MIA team filed #717044; a
random user deciding to ITA the package out of the blue is more or
less "hijacking" the package. Please follow the steps outlined in
devref 5.9.4/5.9.5 [2] to properly orphan a package and adopt it.

Regards,
Vincent

[1] https://launchpad.net/unico
[2] https://www.debian.org/doc/manuals/developers-reference/pkgs.html#orphaning


Reply to: