On Mon, Apr 6, 2015 at 10:24 PM, Jörg Frings-Fürst <debian@jff-webhosting.net> wrote: > Hello, > > I have refresh the package bitz-server[1]. > > Please can someone review it? I am not a DD, but I will try to do my best to review this. It includes a library in its sources, https://github.com/uditha-atukorala/socket-library This library also creates a strange "unknown" author in the debian/copyright file. I am not sure if either of those are acceptable, however I am sure the first one is at least discouraged (in favor of packaging the library separately and listing it in the build depends). Also, I have attached an Upstart job for you to include if you would like. Just place it at the path debian/bitz-server.upstart and it will be automatically shipped with the package. It is not necessary to include this to get bitz-server packaged, it is just something extra. Good luck, -- Cameron Norman
Attachment:
bitz-server.conf
Description: Binary data