On Wed, 1 Apr 2015 09:20:34 Etienne Millon wrote:
> I refreshed this, forwarded two patches and picked the upstream
> version of one.
Nice. But I meant to use all those headers (except for Applied-Upstream which
I use ocassionally).
> I'm not too familiar with how icons work, so I've installed them as
> /usr/share/icons/hicolor/NxN/apps/opentyrian.png. Is that correct?
Yes it is correct. Thanks for installing all icons nicely.
> > * Re-distribution of pre-built binary "macosx/tyrian.icns" in
> > source archive may be a bit of concern.
>
> It's being removed in the next release:
That's good but let's repack orig.tar to remove this file unless you want to
wait till next release. Ftp-masterd do not like blobs and I'm not sure if they
will be willing to tolerate this particular one. Better not take chances and
not waste their time.
Repacking is easy:
* changelog: change version to "2.1.20130907+dfsg-1"
* copyright: add "Files-Excluded: macosx/tyrian.icns" to top section (under
Source).
* watch: add
opts=repacksuffix=+dfsg,dversionmangle=s{\+dfsg\d*}{} \
before URL.
and get repacked orig.tar using `uscan`.
Speaking about watch file I recommend to extend regex to match other types of
archives, something like
opentyrian-(.*)-src\.tar\.(?:gz|bz2|xz)
Too many times I've seen new releases not noticed because upstream changed tar
compression...
> > * There is a comma "," which is not present in the original copyright
> >
> > statement after copyright year in
> > ~~~~
> >
> > Files: ./src/video_scale_hqNx.c
> > Copyright: 2003, MaxSt ( maxst@hiend3d.com )
> >
> > ~~~~
> > IMHO it should be just "2003", not "2003,".
> > Other than this "debian/copyright" looks good.
>
> Indeed, fixed that.
Thanks. I think same issue exists in copyright of Andrea Mazzoleni.
Could you fix it too please?
I'll have a look again once those changes are done and hopefully we'll upload
it.
--
Cheers,
Dmitry Smirnov.
Attachment:
signature.asc
Description: This is a digitally signed message part.